Repository navigation
Conversation
|
#9873 has merged into Scope checked by GPT-6 in Codex and Codex Medium against the current diffs and landed fix; independence is not guaranteed. No runtime tests were rerun for this reconciliation. |
|
Thanks, good catch. Rebased onto current
Tests: |
5a8dc55 to
2203802
Compare
[Medium impact] The PR appears safe to merge; no outstanding finding or actionable new issue was identified. SummaryThe PR moves fingerprint setup into a shell overlay while retaining the terminal-based fallback. It adds guided enrollment, a privileged helper for package installation and login configuration, and tests for hand-off and result handling.
|
|
Addressed all three in 57af12f:
Also fixed while there: Every |
57af12f to
a76b02d
Compare
|
Thanks for the second pass. Both points are addressed, and I took the opportunity to go through the whole change once more; the branch is now a single commit on current Your two comments
From the wider review
New tests cover the overlay hand-over, |
|
We have a settings prototype using standard fprintd D-Bus and would like to consolidate its generic behavior into this overlay. Useful additions are explicit replacement confirmation, rechecking enrolled fingers after Claim, confirmed single-finger deletion without a delete-all fallback, and precise duplicate/full/busy handling. Our stock/unknown Egis path blocks Test because verification/storage reconciliation can lose registrations. We can contribute isolated private-bus fixtures and a narrow verification-safety policy while preserving your setup/PAM/privilege flow. Our latest candidate’s physical acceptance remains pending. — Written by Claude on behalf of @HemangKumawat. |
|
Thanks, glad it's useful. To keep this PR reviewable I'd rather not widen it, but the generic pieces sound like a natural follow-up on top of it once it lands: confirming before replacing an enrolled finger, and single-finger deletion through fprintd's |
|
Rebased onto current |
a76b02d to
94b0cd3
Compare
94b0cd3 to
88f0453
Compare
|
Thanks. All three are fixed, along with related issues found by going through the overlay's request and lifecycle handling as a whole: The three comments
Related
New tests cover the text-flow fallback, |
88f0453 to
d66cc2b
Compare
Setup > Security > Fingerprint opened a terminal that ran fprintd-enroll and printed "place your finger" a number of times. Small press sensors only verify when a press overlaps something enrolled, so an enrollment has to cover the finger, and nothing in that flow said so. Replace it, when the shell is running, with an overlay (omarchy.fingerprint-enroll): - a finger picker for both hands with enrolled fingers marked; - a fingerprint drawn as thin ridges that fill in with every accepted press, a stage counter, and a hint that walks the finger around a spiral (center, above, right, below, left, corners); - instant "hold still" feedback from fprintd's finger-present property, and a plain-language message for each result fprintd can report; - first run: packages, enrollment, one confirming touch, then fingerprint login on; later runs open the picker. The setup logic is not duplicated. omarchy-setup-security-fingerprint gains --enable-login, which runs its existing PAM and omarchy-apply-lock steps (so the lock-screen resume recovery comes along), and hands over to the overlay when the shell is running; without one, the text flow is unchanged. The overlay has no terminal for sudo, so its privileged steps go through omarchy-fingerprint-setup-helper, which re-runs itself through pkexec from its packaged path with PATH pinned, installs the same package transaction, and execs the packaged setup script for --enable-login. Enrolling keeps fprintd's default polkit policy: the user's own password, remembered for a few minutes, so an unlocked session alone cannot add a fingerprint. omarchy-fingerprint-enroll [finger] summons the overlay from scripts (a finger enrolls it and waits for the result, which the overlay writes into a private directory) and falls back to fprintd-enroll without a shell. Works with any fprintd reader.
d66cc2b to
dd639e1
Compare
|
Closing this. The step-by-step terminal setup from #15512 and the platform hook from #16360 now cover the main thing this PR was for: guiding enrollment on press sensors. Rebasing a large overlay onto it doesn't seem worth the review cost. If an on-screen flow is wanted later, I'm happy to rebuild it on top of the current setup script. Thanks for the work on the fingerprint flow. Support for the reader that started this (Elan 04f3:0c3d) is going upstream in libfprint instead: https://gitlab.freedesktop.org/libfprint/libfprint/-/merge_requests/654 |
What
Turns Setup > Security > Fingerprint into a phone-style overlay in the shell, instead of a terminal running
fprintd-enroll.screenrecording-2026-09-07_13-12-00.mp4
finger-presentproperty.Works with any fprintd reader (stage count comes from fprintd over D-Bus). Without a running shell (TTY, SSH) the existing text flow runs unchanged.
How
The setup logic is not duplicated.
bin/omarchy-setup-security-fingerprintgains--enable-login, which runs its existing PAM step andomarchy-apply-lock(so the resume recovery from Fix fingerprint enrollment and lock-screen recovery #7158 comes along), and hands over to the overlay once it is confirmed on screen. If the overlay cannot open, it continues with its text flow, which is untouched apart from calling the sameenable_fingerprint_loginfunction; from the menu (--menu) that text flow reopens in a terminal (--text).bin/omarchy-fingerprint-setup-helper(hidden): the overlay has no terminal for sudo, so its privileged steps go through this, following theomarchy-dnspattern: it re-runs itself throughpkexecfrom/usr/binwithPATHpinned, runs the same package transaction as the setup script, and execs the packaged setup script for--enable-login.shell/plugins/fingerprint-enroll/— the overlay (Enroll.qml,FingerprintGlyph.qmlcanvas,EnrollModel.jsparsing and hints).bin/omarchy-fingerprint-enroll [finger]— summons the overlay; with a finger it enrolls that one and exits 0 or 1 likefprintd-enroll, reading the result from a private temporary directory. The overlay takes one request at a time and answersisOpen()/handles(doneFile)overomarchy-shell shell call, so a waiting script stops within seconds if the overlay goes away. Each request carries a deadline: the overlay refuses one the shell delivers late, and the wrapper falls back only once the deadline has passed, so a slow-loading overlay and the text flow never both run. Without the overlay it falls back tofprintd-enrollin a terminal, and fails without one.omarchy-setup-security-fingerprint --menudirectly;GROUP_DESCRIPTIONSgainsfingerprint. All overlay text goes throughI18n.t()with English entries indefault/i18n/en/shell.json.Security
PATHpinned; polkit-1 is still written by the setup script withinclude system-auth(Defer to system-auth in the polkit stack written by fingerprint/FIDO2 setup #9873).Tests
fingerprint-package-test.sh: new cases for the overlay hand-over, the text-flow fallback when the overlay cannot open,--menureopening in a terminal,--text,--enable-login(lock confirmation required, nothing else runs), and the helper's install step run against the package stub (fresh, already installed, failed transaction).fingerprint-enroll-test.sh: result parsing, cancelled password prompts, D-Bus errors kept out of the overlay, finger names and catalog keys, placement hints, and the wrapper against a stubbed shell: result delivery, picker confirmation, an overlay that vanishes mid-request (fails in seconds), an overlay that loads slowly, giving up only after the request's deadline, no terminal, and an invalid finger name.test/shell.dtest run on this branch and onquattro: no failures unique to this branch.Try it