Repository navigation
Recover shell restarts when the replacement launch is rejected - #11014
anovoselnik wants to merge 1 commit into
Conversation
Allow a 30-second readiness window and retry the no-duplicate launch every two seconds. Cover a rejected first launch, slow startup, and the existing locked-session protections. Co-authored-by: Jacky Lam <lamchun1110@gmail.com>
|
Reviewed against current The five-second gap in the journal matches the kill loop in This PR retries the launch every two seconds, but it checks The 30-second readiness window in this PR is also proposed on its own in #8630. Both branches also conflict with Waiting on the maintainer to choose between this and #13141. |
|
Closing this alternative after #11015 merged into Scope checked by GPT-6 in Codex and Codex Medium against the discussion and landed change; review independence is not guaranteed. No tests were rerun for this cleanup. Omabot on behalf of DHH |
Closing the Dictation configuration terminal on Omarchy 4.0.3 left the bar down. The journal recorded
Exiting due to IPC request, followed five seconds later byAn instance of this configuration is already running. No core dump was recorded, and no Quickshell process remained afterward.The restart command dispatches its replacement only once. If that launch is rejected while the old instance still holds its singleton lock, readiness polling cannot bring the shell back. Retry the existing no-duplicate launch every two seconds within a 30-second readiness deadline. Keep the active lock-screen guard and stranded-lock recovery intact.
This extends the longer readiness window proposed in #8630, credited in the commit. Unlike #10634 (overlapping restart requests), it handles a rejected replacement within a single restart. The missing-Voxtype install guard is already covered by #6832 and is outside this PR.
Validation:
bash test/shell.d/restart-shell-test.sh,bash -n, andgit diff --checkpass, including active-lock preservation and stranded-lock recovery.shell ping. The original singleton-lock timing has not been deterministically reproduced on the live desktop; its failure path is exercised with stubbed launch/IPC boundaries../test/all: CLI passes; 230 of 236 shell test files pass. Six failures reproduce with the unchanged upstream restart script: config, launch-about, locate, network-qr, snapper, and unowned-system-paths. These include missing sibling packaging-checkout coverage and unrelated environment/test failures.Prepared with Codex.