Repository navigation
Conversation
Enabling, disabling and removing plugins are all things people do to a handful of them in one sitting, and the menu could only ever answer with one, so each extra plugin meant walking the same three-level menu again. Adds a multi-select mode to the menu's select surface, reached with `omarchy-menu-select ... -- --multi`: Tab ticks the row under the cursor, a checkbox trails every row, the prompt line reports the tally, and Enter confirms with one option per line. Ticks are keyed by the value the row would return, so a row stays ticked while the search narrows the list around it. Enter with nothing ticked returns the row under the cursor, so callers never handle single and multiple picks as separate shapes. Typing goes to the filter here as it does everywhere else in the menu, which is why the toggle is Tab and not Space. The plugin picker opens enable, disable and remove as multi-pickers and names the plugins a batch could not act on. Clone still picks one; it ends in an editor. A batch of removals is one terminal, but still one confirmation each, so the destructive path is unchanged per plugin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCMPJn3g2jq8ijgCgCDvuc
4 tasks done
|
This conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling, disabling and removing plugins are all things people do to a handful of them in one sitting, and the menu could only ever answer with one, so each extra plugin meant walking the same three-level menu again.
Multi-select in the menu's select surface
omarchy-menu-select ... -- --multiaddsmultiSelect: trueto the summon payload and turns the list into a multi-picker:Tab to select→2 selected)Typing goes to the filter here as it does everywhere else in the menu, which is why the toggle is Tab and not Space — plugin names contain spaces.
Plugin picker
omarchy-menu-pluginopens enable, disable and remove as multi-pickers and names the plugins a batch could not act on. Clone still picks one; it ends in an editor. A batch of removals is one terminal, but still one confirmation per plugin, so the destructive path is unchanged per plugin.Incidental refactor
Two places were parsing the
glyph\tlabel\tsubtextoption format, and they disagreed on the two-part form. There is now oneparseDmenuOption, read by both the rows and the answer — if those drift, a ticked row comes back as something the caller never offered. A test pins the parser to a single call site.Verification
test/shell.d/menu-test.sh(127 assertions) andtest/shell.d/menu-plugin-test.sh(17) pass. New coverage: the ordering of the answer, the fallback to the cursor row, the Tab/Enter wiring, the single parser, the--multipayload flag, and — through the existing stub harness — that a batch enables only what was picked, that clone stays single, that a batch of removals is one command per plugin, and that a partial failure is reported rather than silent../test/shellotherwise unchanged (the 4 failures on this machine —config,locate,snapper,unowned-system-paths— reproduce on a cleanquattrocheckout).wtypeand screenshots peragents/skills/visual-verification.md: ticking, the tally, a tick surviving a filter narrowing and clearing, the returned value, and that single-select and the ordinary menu are visually unchanged. One fix came out of that pass — the check mark was drawn in the selected row's background and was near-invisible on the cursor row; it now uses the card's own ground, which is a text-contrast pair either way.🤖 Generated with Claude Code
https://claude.ai/code/session_01VCMPJn3g2jq8ijgCgCDvuc