Repository navigation
Conversation
johnpippett
left a comment
There was a problem hiding this comment.
With no /tmp/omarchy-update.log, the command prints No update log found; nothing to analyze. and returns status 0. It writes no error output.
Source commit: cee7e3d4a61c445c6b53a852192737eb54c5db64.
Comparison base: 8ea51516390320f8e768808b230098e67bdaa82c.
Codex did the local tests on Arch Linux with Bash 5.3.15 and Bubblewrap 0.11.2.
The test environment had read-only source, temporary user files, and no access to the desktop or network.
The comparison included 22 command cases and five test-suite executions. Each command gave the expected output and exit status. All five executions of the test suites returned status 0.
The cases included direct execution and command-line interface (CLI) routing.
Other cases used missing or empty logs, unrelated output, and successful or failed initramfs messages.
The direct cases used the production path. The added upstream test uses a substitute path.
The update-status and update-sequence tests used substitute commands. An independent execution gave the same results.
With an unreadable log, the command prints Permission denied and returns status 0 on both revisions. This behavior is outside the missing-file correction.
These results do not include a system update, an initramfs operation, the full shell suite, or graphical acceptance tests.
|
Reviewed at Tests ran on the worker, on this head and on it merged into current This review is Claude Opus 5.5's alone. The second opinion, Codex Medium, did not run: today's review budget was already spent, so nobody has checked this reading of it. Nothing is left for you. It waits on a second review and then on the maintainer. |
|
Thanks for the worker check. Leaving the branch as-is at cee7e3d — missing-log path exits 0, initramfs checks unchanged, and the unrelated vscode theme failure is on quattro too. Happy to wait on the second review. |
cee7e3d to
b0f7d01
Compare
[Low impact] The PR appears safe to merge, with no outstanding findings. SummaryThe PR makes
No new actionable issues were found. Reviews (2) · Last reviewed commit: "Describe how the analyze-logs test isola..." · Reviewed by Greptile |
The base branch's AGENTS.md asks for a full conditional rather than an exit in one branch that leaves the rest unreachable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The comment said the test points TMPDIR away, which it never does; the sed copy is what keeps the host's log out of it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-reviewed at I pushed two small commits on top:
Checked on an Omarchy worker, with this head merged into The second opinion came from Codex Medium and muse-wonder (pi, thinking high). Both reviewed this head and found nothing; they read my brief, so their agreement is not guaranteed independent. They were also asked to compare this with the other open pull requests that guard the missing log as part of other fixes: #13937, #14062, #15683 and #17012. Both said this one, the oldest, is the fix for #11204. Those four change the same lines of Nothing is left for you; it waits on the maintainer. |
The private transcript fix does not need to silence a missing legacy log. Preserve the existing grep diagnostic instead of making an analysis that read nothing look clean; the separate missing-log diagnostic in omacom#11217 can still land on its own. Remove a redundant move in the analyzer fixture. Co-Authored-By: GPT-6 High <noreply@openai.com> Co-Authored-By: Opus 5.5 High <noreply@anthropic.com>
Why
omarchy update analyze logsis a standalone command. When/tmp/omarchy-update.logdoes not exist (fresh boot, never updated this session), the script greps it anyway and dumps:Fixes #11204.
What
Check the log exists first. Print
No update log found; nothing to analyze.and exit 0. Existing initramfs checks are unchanged.Proof
test/shell.d/update-analyze-logs-test.shcovers missing file, failed initramfs, and successful initramfs.Does not ping maintainers.