Repository navigation
Allow restarting shell when desktop locked - #11240
Open
nick1udwig wants to merge 1 commit into
Open
nick1udwig wants to merge 1 commit into
nick1udwig wants to merge 1 commit into
Conversation
This was referenced Oct 11, 2026
|
Big architectural change (independent
I'd treat this as a product/security-sensitive review rather than a drive-by merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Developing plugins can require restarting the shell.
Developers might reasonably want to lock their machine and continue development with a remote solution (ChatGPT remote, Claude remote control, etc).
However,
omarchy-restart-shellrefuses to run if the machine is locked because the locker is run in the shell and if the shell fails to restart the session may be unrecoverable.Solution
Split out the locker into its own shell, removing the risk of breaking the locker when restarting the shell.
Notes
Why not just turn on screensaver instead of locking?
If I want to develop a plugin that requires restarting the shell right now, I have to either sit at my keyboard OR leave my system unlocked.
This dichotomy is not great: either make devex worse or security worse.
In general, as much dev as possible should be able to be done securely and remotely from my machine.
This PR is in that spirit.
Splitting out the locker only costs ~20MiB private memory and ~30 MiB PSS at peak
With narenas:2, the locker only uses ~20MiB more private memory and ~30MiB PSS at peak than the current quattro branch.
Benchmark: locker.py. Use like: