Skip to content

Accept bar style tokens from shell config - #11407

Closed
thelonewander3r wants to merge 1 commit into
omacom:quattrofrom
thelonewander3r:fix/bar-style-config-tokens
Closed

thelonewander3r wants to merge 1 commit into
omacom:quattrofrom
thelonewander3r:fix/bar-style-config-tokens

Conversation

@thelonewander3r

Copy link
Copy Markdown

What

  • Accept icon-slot, icon-canvas, icon-font, and status-slot from the bar section of shell.toml.
  • Add a focused shell test covering all six supported bar metric tokens.

Why

Style.qml already exposes and consumes these four tokens through barToken(), but applyShellValues() silently discarded them. This makes the documented configuration surface unreachable while size-horizontal and size-vertical work.

Testing

  • bash -n test/shell.d/bar-style-config-test.sh
  • bash test/shell.d/bar-style-config-test.sh
  • git diff --check upstream/quattro...HEAD

Fixes #11359

@bjarneo

bjarneo commented Sep 21, 2026

Copy link
Copy Markdown
Member

Automated duplication check: this pull request looks similar to #6587, which covers the same bar style token parsing. I keep that one open and close this one to consolidate review.

If you feel this is the wrong decision, please open the PR again with a note on the difference.

@bjarneo bjarneo closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bar icon-font / icon-canvas / icon-slot / status-slot are defined and read via barToken() but silently dropped when parsing shell.toml

2 participants