Repository navigation
Conversation
Member
|
Automated duplication check: this pull request looks similar to #11520, which covers the same screenrecording stop single-flight. I keep that one open and close this one to consolidate review. If you feel this is the wrong decision, please open the PR again with a note on the difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11508
Problem
When
gpu-screen-recordertakes a moment to exit after SIGINT (such as when draining queues or encoding at higher resolutions), triggering stop again (e.g. via hotkey or menu) callsstop_screenrecordingconcurrently. This results in:/tmp/omarchy-screenrecord-filenamebefore removal and racing to generate previews and post notifications, causing duplicate toasts and broken thumbnail images.Fix
${XDG_RUNTIME_DIR:-/tmp}/omarchy-screenrecord-stop.lockat the top ofstop_screenrecordingusingexec {lock_fd}>...; flock -n "$lock_fd" || return 0.[[ -n $filename && -f $filename ]].test/shell.d/screenrecording-test.shverifying single-flight stop lock and that saved toasts are skipped when the recording file is missing.