Repository navigation
Conversation
omarchy-hw-fingerprint only proves a reader is present, not that libfprint can drive it. Readers like Goodix TLS-encrypted sensors (27c6:55b4, found on the ThinkPad L13 Yoga Gen 3) or an Elan MOC sensor outside the elanmoc table enumerate on USB but have no libfprint driver at all, so enrollment fails no matter how many times it's retried. Check fprintd-list before attempting enrollment and bail with a clear message when it reports zero devices, instead of sending the user through fprintd-enroll and telling them to try again. Fixes omacom#11841 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SMHmPqFQQroLFtP5t8Athe
Automated AI review
Outcome: The new check reports every Any
|
fprintd-list exits 1 for more than an empty device list: a daemon or D-Bus failure, or a denied verify permission (any session polkit does not treat as local and active, such as SSH). On a supported reader those were all reported as "libfprint has no driver for it". Match the "No devices available" line fprintd prints for an empty list, and leave every other failure to enrollment as before. fprintd-enroll does not hang without a device: GetDefaultDevice returns NoSuchDevice and it exits at once, so the comment now says that. The test now checks the message is printed, and that another fprintd-list error still reaches enrollment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
[Medium impact] The PR appears safe to merge; the earlier diagnosis concern is addressed. SummaryAdds a check with
No new actionable issues were found. Reviews (3) · Last reviewed commit: "Say fprintd has no usable device, and th..." · Reviewed by Greptile |
|
Reviewed and reproduced, with one fix pushed to your branch. Reproduction. I ran this on a disposable Omarchy VM with real Pushed: fc38b33. Second opinion. Codex at medium effort reviewed it twice. It raised the daemon and D-Bus failures behind the broad exit-status check and the untested message, and agreed with the hang correction. Its independence from this review is not guaranteed. On the fixed head it found one remaining point, left for the maintainer rather than changed here: an empty device list proves fprintd sees no reader, not that the sensor is unsupported. A supported reader that disconnects after detection would get the same "isn't supported yet, retrying won't help" message. That wording is your call and the maintainer's. Related. #12480 fixes the same bug with a This is waiting on the maintainer: whether to keep the message as worded, and which of this and #12480 to take. |
Keeps both sets of new cases in fingerprint-package-test.sh: the no-driver diagnosis cases from this branch and quattro's apply-lock setup cases from omacom#7158. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged The conflict. #7158 landed on Verification. I ran this on a disposable Omarchy VM with real Second opinion. Codex at medium effort reviewed the merge. It found the conflict resolution correct, found no interaction with #7158's apply-lock changes, and judged the fix proportionate. It agreed with this review, and its independence from it is not guaranteed. It raised one point again: an empty device list shows that fprintd cannot use the reader, not that libfprint lacks a driver for it. So "this exact sensor isn't supported yet, retrying won't help" claims more than the check proves. Its suggestion was "A fingerprint reader was detected, but fprintd cannot use it. This may mean the installed libfprint does not support this sensor." I have not changed it, because user-facing wording is the maintainer's call and yours. This is waiting on the maintainer: whether to keep the message as worded. |
…kely cause An empty fprintd device list shows fprintd cannot use the reader, not that libfprint has no driver for it: a driver that failed to initialise leaves the same empty list. So the message no longer says the sensor isn't supported or that retrying won't help; it says fprintd has no usable device, that libfprint most likely has no driver, and to look the USB ID up with lsusb. A new case checks that a failed scan on a reader fprintd can see still asks for a retry. Both come from omacom#15080, which made the same fix after enrollment and is folded in here. Co-Authored-By: Omarchybot <317366263+omarchybot@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pushed one commit to your branch, 6f83c77, which folds in the parts of #15080 that this pull request did not have, and verified it again. What changed and why. fprintd lists no device when libfprint has no driver for the reader, but also when a driver exists and failed to initialise. So "libfprint has no driver for it" and "this exact sensor isn't supported yet, retrying won't help" claimed more than the check shows. The message now reads "Your fingerprint reader was detected, but fprintd has no usable device. libfprint most likely has no driver for this reader." The second line now says to look up the reader's USB ID (shown by Verification. I ran this on a disposable Omarchy VM with real Second opinion. Codex at medium effort reviewed the head and found no defects. It confirmed that the tests reject both a version that drops the message and one that treats every Related. #11047 adds a python-validity hint for four Synaptics/Validity readers on the path after a failed enrollment, and it also keys on This is waiting on CI for the new head, and then on the maintainer. |
Summary
omarchy setup security fingerprintsends readers with no libfprint driver at all (e.g. Goodix TLS-encrypted sensors like27c6:55b4on the ThinkPad L13 Yoga Gen 3) throughfprintd-enrolland tells the user to "try again" on failure — advice that can never work, since libfprint has nothing to enroll against.fprintd-list "$USER"check before enrollment. It reliably exits 1 with "No devices available" when libfprint has no driver for the detected reader (verified against fprintd's own source). On that path, print a clear message pointing at the supported-devices list and the Discord instead of attempting enrollment.Test plan
fprintd-liststub and a new case totest/shell.d/fingerprint-package-test.shcovering the zero-driver pathbash test/shell.d/fingerprint-package-test.sh— all 6 cases passbash test/shell(full shell suite) — no new failures; the 5 pre-existing failures (config-test.sh,snapper-test.sh,unowned-system-paths-test.sh,locate-test.sh,bar-widget-contract-test.sh) reproduce identically on a clean checkout with this change stashed out, and are caused by environment setup unrelated to this change (missingOMARCHY_PKGS_PATHcheckout, a stray non-UTF8 file, and one flaky run)27c6:55b4🤖 Generated with Claude Code
https://claude.ai/code/session_01SMHmPqFQQroLFtP5t8Athe
Fixes #10892