Repository navigation
Drop macbook12-spi-driver-dkms, which no longer builds on 7.x kernels - #12007
karlentwistle wants to merge 1 commit into
Conversation
applespi is in mainline and drives the keyboard and trackpad on SPI MacBooks. The out-of-tree package fails its DKMS build on 7.x kernels, so every kernel update prints an error for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Sounds like it should be forked, fixed, and the upstreamed stuff removed. |
|
Thanks for this, @karlentwistle. It makes the same change as #9880, opened on 2 September against What makes them the same: both stop Your MacBook9,1 result (package removed, UKI rebuilt, keyboard working at the LUKS prompt and in the session on 7.2.3) is real hardware evidence that #9880 does not have, so it would be worth repeating as a comment there. Your note about the 2016–17 Touch Bar models also applies to both pull requests. I compared the two diffs by reading them. Codex Medium was asked separately, from the two pull requests alone, and also judged them the same change. If I have this wrong, say so and this can be reopened. |
install/hardware/apple/fix-spi-keyboard.shinstallsmacbook12-spi-driver-dkmson SPI-keyboard MacBooks, but the package no longer builds against 7.x kernels (linux-omarchyis 7.2.3). On 7.2.3 the DKMS build fails whenever headers are installed or the kernel updates:The keyboard and trackpad don't depend on it:
applespihas been in mainline since 5.3, and it's what gets loaded (/lib/modules/7.2.3-arch1-3/kernel/drivers/input/keyboard/applespi.ko.zst). The mkinitcpioMODULESdrop-in only names in-tree modules, so it stays as it is.Changes:
fix-spi-keyboard.shomarchy-other.packagesTested on a MacBook9,1 (Omarchy 4.0.3, kernel 7.2.3-arch1-3): removed the package, the UKI rebuilt cleanly, and after a reboot the keyboard works at the LUKS prompt and in the session. The migration no-ops when the package is absent.
./test/cliandtest/shell.d/t2-hardware-test.sh(which readsomarchy-other.packages) pass.One note for the 2016–17 Touch Bar MacBook Pros (MacBookPro13,2/13,3/14,2/14,3): the Touch Bar and ambient light sensor drivers came from this package. They already fail to build, so removing it doesn't take anything away that currently works, but I haven't been able to test on those models.
🤖 Generated with Claude Code