Repository navigation
Conversation
The lock screen reused one Quickshell PamContext for every fingerprint attempt. Once its first session completed or errored, PamContext.active stayed set, so startFingerprint() never started another scan: at most one fingerprint attempt per lock, and a single miss disabled the reader until password unlock. Create a fresh PamContext per attempt via a Component factory, stop scanning while the display is blanked (gating on the existing displaysBlank state) and re-arm on wake, and suspend the fingerprint flow while a password prompt is in flight.
|
Confirming the gating on the reader you cite — Broadcom 58200 / CV3 Citadel ( The gating works. Armed only while a display is awake: 0 refusals across a 15-minute lock, first-touch read on wake. Before it, 31,534 The single-session premise doesn't hold on quattro r2153. The reader gets far more than one PAM session per lock here: those 31,534 refusals arrived at ~4/s across thousands of distinct Your point about not aborting an in-flight scan looks right. My local version aborts the session when the 45 s grace expires; I haven't hit the dead-reader case you describe, but I can't rule it out either, and the reasoning matches this hardware — |
|
Thanks — the 31,534→0 refusal numbers (and the 205s/122s cycle) confirm the gating is the load-bearing fix, and I agree On the single-session premise: I can reconcile it as failure-mode-specific rather than version-specific. There are two distinct ways the driver fails here, and they behave differently in stock code:
I have seen both on the packaged 4.0.4 within one day, so I do not think it is a version regression; the thermal storm and the cold-driver first scan just never overlap in a way that exposes both. Happy to split the PR: the gating (+ wake re-arm, + not aborting in-flight) as the primary fix, and the |
|
Split it, gating first — for what it's worth from a non-maintainer. The gating half has four vendors behind it now (04f3:0c4b, @bmcswee's measurement, Goodix 27c6:533c, Broadcom CV3 here) and is purely additive against stock: retry-timer stop on blank, The Happy to test it on CV3 once it's split out. |
|
Splitting per the thread. Superseded by two PRs:
Closing this combined PR in favor of those. |
PR: Re-arm lock screen fingerprint reader after a missed/errored scan
File:
shell/plugins/lock/Service.qml(lock plugin)What & why
One Quickshell
PamContextis reused for the whole lock. After its firstsession completes or errors,
fingerprintPam.activenever returns to false,so
startFingerprint()never starts another scan. Fingerprint unlock is atmost one attempt per lock — a single miss or driver error disables the reader
until you unlock with the password.
This change:
PamContext { id: fingerprintPam }with aComponentfactory; each attempt creates a fresh instance (
fingerprintPamInstance),so a miss/error no longer kills the reader for the lock.
runBlank) it stops the retry timer and gatesstartFingerprint()on the existingdisplaysBlankstate, so no new scanstarts while blanked (without this some drivers, e.g. the Broadcom 58200
TOD, scan continuously and hit a thermal self-disable). An in-flight scan is
allowed to finish: aborting the pam session on blank severed a scan the
reader was still servicing, and since the reader is not a compositor wake
source that left it dead until password unlock.
runWake).No new configuration is required. Behavior without a reader configured is
unchanged (
fingerprintConfiguredfalse → never started).How to apply
Validated on Omarchy 4.0.4 with a Broadcom ControlVault 3 reader
(
0a5c:5843, fprintd 1.94.5): after a first-scan error, subsequent scanssucceed, including after a multi-minute locked+blanked period followed by wake.
Suggested commit message