Repository navigation
Conversation
nohup does not keep the delayed `uwsm stop` alive once the invoking scope is reaped, so Logout closes windows and never ends the session.
Automated AI review
Verified: The change is correct and brings logout in line with reboot and shutdown.
Verified (repository test): In an isolated sandbox, "Fixes #12233" is not demonstrated for the menu pathThe PR description attributes the failure to the invoking systemd scope being reaped when the script exits or the terminal closes. On the path reported in #12233 (menu > System > Logout), the source does not show any step that would kill the old delayed job: A systemd scope is not stopped when one of its processes exits. It stays alive while any process remains in it. Closing the other windows does not stop the compositor unit either. On this path the base job should therefore survive to run Impact: Closing #12233 on the basis of this PR could leave the reported failure in place if its cause lies outside the caller-lifetime class. Suggested change: Confirm with one real menu logout on a disposable machine or VM before treating #12233 as fixed. Alternatively, on an affected system with the old script, Optional test improvement: The test mocks only Review informationTest scope: Source review of the pinned head AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
Match the reboot comment, and stub uwsm, systemctl, and the OSD so the power tests cannot stop the session or toast the desktop.
Automated AI review
Follow-up to the earlier review and the author reply, checked at Outcome:
Verified: In an isolated sandbox, every backend the power test could reach (
|
|
Thanks for catching both of these. Fixed in ee3b168.
The related-PR notes are useful. I have kept this branch's one-attempt logout expectation; if #11151 lands first, the combined test needs per-action counts. I have not folded the other scheduling changes into this PR or tested a live logout. |
Automated AI review
Outcome: No defects found. Follow-up to the second review and the author reply, checked at
#10353, #7501 and #7434 also conflict in the logout script (below). Verified
Reproducer (passes at ee3b168)Checks at ee3b168. git ls-tree ee3b1684 bin/omarchy-system-logout test/shell.d/system-power-test.sh
bash test/shell.d/system-power-test.sh; echo "exit=$?"
bin/omarchy logout --help; echo "exit=$?"Actual output:
Negative controls at ee3b168 (same test, only
Trial merge of ee3b168 into Related open PRs
Reproducer (#11151 merged test)Merge this PR (ee3b168) and #11151 (901d9aa) onto git fetch origin quattro pull/12254/head:pr-12254 pull/11151/head:pr-11151
git checkout --detach origin/quattro
git merge --no-edit pr-12254
git merge --no-edit pr-11151
bash test/shell.d/system-power-test.sh; echo "exit=$?"Actual output (isolated sandbox, merged tree of b421b1b + ee3b168 + 901d9aa): The merged failure loop is Review informationTest scope: Source review and sandboxed tests with all backends stubbed, at AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
Reviewed at What ran, on a disposable Omarchy worker with a live Hyprland session:
So on a stock install the Second opinion: Codex at medium effort reviewed the diff. It found no defect and, like me, could not name a stock context where the old job gets killed. It agrees with what was already written here, and its independence is not guaranteed. It also noted that the test checks the scheduling call, not the timer running, which is what the worker run above covered. Next: waiting on the maintainer to decide whether to take this for consistency with reboot and shutdown without a reproduced failure. Nothing is needed from the author. |
|
|
Thank you for testing both the terminal and menu paths. I’ve taken the distinction between a consistency improvement and a reproduced bug fix: the description and source comment now make that clear, and #12233 remains open. Current The power test passes all 11 assertions, the CLI suite passes all 117 assertions, and metadata, syntax and diff checks pass. No live logout was initiated. Whether to take this scheduling consistency change remains the maintainer’s decision. |
This proposal scheduled logout outside the terminal that requested it. Current
quattroimplements that behavior in the consolidatedbin/omarchy-systemcommand, introduced by #15231 (4bf51ed1). It runs logout, reboot and shutdown in bounded user services and waits for application exit with a deadline.Merged current
quattroine77d912d, resolving the obsolete logout-script modify/delete conflict by keeping upstream's consolidated implementation and its tests. The resulting branch has zero file differences fromquattro; this PR is superseded by #15231.Validation: the system-power suite passes, including logout scheduling, caller-environment forwarding, bounded window cleanup, failed scheduling, rejected exit requests and command routing. The full CLI suite also passes in the companion confirmation checkout at the same upstream revision. No live logout was initiated.
The earlier worker review did not reproduce the menu logout failure in #12233; this PR does not establish that issue as fixed.