Repository navigation
Conversation
The reader re-arms a quarter second after a rejection, so a failed scan looked the same as one still listening. Pass fingerprintAuthenticating and a failure nonce into LockView: the glyph pulses while PAM waits, then turns urgent, nudges, and shows "Try again" on a rejection. The polkit prompt gets the same pulse while it waits on the reader.
Add an easeOutExpo curve, open windows with a slightly stronger pop, close them on the same curve instead of linear, and enable the fade switch.
|
I am not a mentainer, but I think you should make a separate PR for the looknfeel.lua change. Also, this seams a personal change. Good work on the fingerprint reader bug fix. Looks good, hope it gets merged. |
This was referenced Sep 28, 2026
|
Rejected-scan feedback on the lock glyph is a real gap (today a fail looks like still-listening). CONFLICTING vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the lock screen, a rejected fingerprint read re-arms the reader about a quarter second later, so a failed scan looked exactly like one that was still listening.
Service.qmlalready trackedfingerprintAuthenticating, but never passed it intoLockView.This passes that flag plus a failure nonce into
LockViewand:Retry backoff
While testing this against a reader that sometimes wedges, I hit a worse failure than a missed animation. When
pam_fprintdfails before it ever asks for a finger — a stale device, no enrolled prints, a busy reader — PAM returns in well under the retry interval. The old fixed 250ms retry then re-ran the failure immediately, and because every failure re-armed the retry, one flaky moment turned into a tight loop: thousands of PAM sessions a minute, each claiming the fingerprint device, which kept the reader wedged and left "Try again" strobing on the lock screen.The service now records whether the reader ever engaged (
onPamMessage), and the retry changes shape accordingly:A backoff also can't be mistaken for a dead prompt, because a rejected scan still re-arms at once.
Tests
test/shell.d/lock-fingerprint-feedback-test.sh: the service raises the failure signal, the view receives the live state, and both failure paths retry through the shared helpertest/shell.d/lock-fingerprint-retry-test.sh(new): loads the service and asserts an unengaged failure backs off without flagging a miss, while an engaged failure re-arms and flags ittest/shell.d/lock-fingerprint-indicator-test.sh: the retry label appears on a rejectiontest/shell.d/polkit-fingerprint-animation-test.sh(new): the polkit glyph pulses only while the prompt is liveVerification
The polkit pulse was verified in the running shell: capturing the prompt while it waited on the reader showed the center glyph brightness oscillating on the animation's period, and flat when the prompt was gone. The retry behaviour is covered by the headless test above. I could not capture the lock screen itself on this machine, but it uses the same animation mechanism as the polkit prompt.
The retry storm itself was measured on the affected machine: 4518 fingerprint PAM sessions in 20 minutes before the change, 1 in the 25 minutes after.
Notes
This overlaps #10393, which also reworks the retry loop in
Service.qml. Whichever lands second needs a rebase, but the two are complementary: that PR changes how often the reader retries, this one makes each outcome visible and stops the retry from spinning when the reader is not there.The second commit touches
default/hypr/looknfeel.lua(window open/close motion). It is unrelated to the fingerprint work, so I'm happy to drop it or split it into its own PR.