Skip to content

Let GUI-started update prompts be answered with the mouse - #12359

Open
z23 wants to merge 8 commits into
omacom:quattrofrom
z23:fix/confirm-accepts-mouse
Open

z23 wants to merge 8 commits into
omacom:quattrofrom
z23:fix/confirm-accepts-mouse

Conversation

@z23

@z23 z23 commented Sep 18, 2026 •

Copy link
Copy Markdown

Clicking the shell update affordance opens a floating terminal, but gum's confirmation buttons ignore mouse clicks. omarchy-confirm supplies an inline fzf yes/no prompt with mouse acceptance, gum-style keyboard controls, custom labels, defaults, and compatible success/cancel exit statuses. The update and reboot prompts use it; a missing fzf falls back to gum.

The prompt clears inherited fzf options and combines --sync with start:pos, selecting the default before fzf handles keys arriving during startup. Identical, empty, or multiline choice labels are rejected before prompting. The update-flow reference documents the shared helper.

Current quattro is merged in fbf17e1a. Conflict resolution retains upstream's consolidated omarchy-system reboot command and compatibility description for omarchy-update-status, while keeping the mouse prompt. The restart regression now checks that accepting the prompt calls the consolidated reboot command; unattended updates still avoid prompting.

Validation: all 80 startup-key trials pass; real-fzf mouse clicks on Yes and No pass under both defaults and hostile inherited options. Prompt/fallback, restart-phase, command-style, Bash syntax, PR diff checks and the full CLI suite pass. A whitespace warning in an unrelated upstream test is excluded from the PR diff check. No live update or reboot was initiated.

Fixes #12348.

gum confirm never opts into mouse events, so clicking Yes in the
floating update terminal did nothing. fzf already accepts left-click.
@llstrk

llstrk commented Sep 25, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Verified: the mouse part works as described. In a terminal emulation using foot's mouse encoding, a single left click on "Yes" returns 0 and on "No" returns 1, clicks on the header or blank rows are ignored, and the result holds through script -qefc and through both updated callers. The prompt stays off the alternate screen, and text, background and selection colours follow the theme. gum confirm never enables mouse reporting, which confirms the cause described in #12348.

Four behaviour issues were reproduced with real fzf 0.74.3 in a pseudo-terminal. The first two affect the two prompts this PR changes.

Keys that answered gum confirm no longer answer, so n then Enter means Yes

gum confirm answers immediately on y/n (and q for No) and toggles with Left, Right and Tab. With --no-input, fzf discards typed characters, and Tab, Left and Right do not move the selection:

Input           gum confirm (base)   omarchy-confirm (head)
n               1 (No)               nothing happens
n, Enter        -                    0 (Yes)
q, Enter        -                    0 (Yes)
Right, Enter    1 (No)               0 (Yes)
Tab, Enter      -                    0 (Yes)
Down, Enter     -                    1 (No)

Impact: on "Continue with update?" and on the post-update reboot prompt, a keyboard user who presses n out of habit sees no response. Pressing Enter afterwards starts the update or reboots the machine.

Suggested change: bind the familiar keys explicitly, for example --bind "y:pos(1)+accept,Y:pos(1)+accept,n:pos(2)+accept,N:pos(2)+accept,q:pos(2)+accept", optionally with left:up,right:down to keep toggling. The y/n bindings were checked on a copy of the helper: n returns 1, y returns 0 and a click on No still returns 1.

fzf is now required on the update path but is not a package dependency

omarchy-confirm always runs fzf. The omarchy package in omarchy-pkgs (4.0.4) lists gum under hard dependencies but not fzf. fzf arrives only through install/omarchy-base.packages (ISO, upgrade-to-quattro, reinstall), and a normal update never re-adds it. With fzf absent (reproduced with fzf removed from PATH):

fzf missing -> pipeline status 127 -> omarchy-confirm exits 130 (same as Esc / Ctrl-C)
  omarchy-update-confirm  -> "Update cancelled", exit 1: every interactive update is refused
  omarchy-update-restart  -> reboot stub not called: reboot offer skipped

Impact: on a standard install this requires the user to have removed fzf, which pacman allows because nothing installed by default hard-depends on it. When it happens, interactive omarchy update cannot be confirmed, and the only hint is fzf: command not found above "Update cancelled". Before this PR, both prompts depended only on gum, which is a declared dependency. The same 130 mapping also reports invalid fzf options or colours as a user abort.

Suggested change: any one of: add fzf to the omarchy package's depends; fall back to gum confirm when command -v fzf fails; or at minimum pass statuses other than 130 through (or print a clear error) instead of mapping every fzf failure to 130.

--default=false usually starts on "Yes"

start:pos(2) runs when fzf starts, before the two-line list has loaded. fzf's manual states that the input list is not available in start without --sync, and pos(2) on an empty list clamps to the first row. With omarchy-confirm --default=false and Enter after both rows rendered:

Variant Answered Yes
Head helper, start:pos(2) 23 of 30 runs; 34 of 40 runs (separate test harnesses)
Head helper changed to load:pos(2) 0 of 20 runs

In the observed runs, the highlighted row before Enter matched the answer, so the wrong default is visible, not an early-keypress artifact.

Impact: the two callers in this PR use the default (Yes), so they are not affected. The helper advertises --default=false in its usage text and examples ("Remove orphans?"), and most of the six existing gum confirm --default=false sites guard removals, such as orphan packages (in the same update flow), VM data and AI data. Migrating them to the helper as it stands would make Yes the effective default most of the time.

Suggested change: use --bind "load:pos($start_pos)" (verified above) or add --sync.

A user's FZF_DEFAULT_OPTS changes the answer

fzf applies FZF_DEFAULT_OPTS_FILE and FZF_DEFAULT_OPTS before the helper's arguments, and the helper does not clear them. Observed with Enter on the default row: --tac returns 1 (No), --print-query makes Yes return 1, and --no-mouse disables mouse reporting.

Impact: only affects users who export these variables into the terminal's environment; Omarchy does not set them. gum confirm had no comparable exposure.

Suggested change: run fzf with FZF_DEFAULT_OPTS= FZF_DEFAULT_OPTS_FILE= (verified on a copy: all tested cases then answer correctly).

Optional test improvement: test/shell.d/confirm-test.sh uses an fzf stub that accepts any arguments. A copy of the helper with --info=hidden changed to --info=bogus still passes all assertions, while real fzf rejects it and every update would be cancelled. The --default=false check asserts the start:pos(2) string, which is the unreliable construct above. Running at least one case against real fzf, when it is installed, would catch both. Setting HOME to the test's temp directory would also stop the test from reading the runner's own theme file.


Review information

Test scope: source review of the PR, its callers and the update flow, plus fzf 0.74.3, gum and foot 1.28.0 source and the omarchy-pkgs omarchy PKGBUILD. Sandboxed pseudo-terminal runs used real fzf with scripted keys and foot-format mouse reports, with a synthetic home directory. Reboot, shell restart and package commands were stubbed, and omarchy update itself was not run. No click-through was performed in a live foot window or other terminal, and the rate of the --default=false race on a real terminal was not measured.

AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments with targeted cross-checks of each other's findings, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

Keep y, n, and q working, select the default row after fzf has loaded the list, ignore FZF_DEFAULT_OPTS, fall back to gum confirm when fzf is missing, and report a real fzf failure instead of a cancel.
@z23

z23 commented Sep 26, 2026

Copy link
Copy Markdown
Author

Thanks for the review. The four behavior findings were right, and they are in 313900a.

  • y / n / q (and Y / N) accept immediately, and left, right, and tab move the selection. n then Enter is No.
  • --default=false uses load:pos(2), after the list exists. Enter on that row returned No against fzf 0.74.
  • FZF_DEFAULT_OPTS and FZF_DEFAULT_OPTS_FILE are unset for this fzf. --tac no longer flips the answer.
  • If fzf is missing, the prompt falls back to gum confirm with the same labels and default, instead of exiting 130. Any other fzf status is passed through. 130 stays the cancel.

I did not add fzf to the omarchy package depends. That list lives in omarchy-pkgs, and the fallback covers a machine where fzf was removed. The two update callers still default to Yes.

The stub test covers the binds, the cleared environment, a non-130 failure, and the gum fallback. When fzf and python3 are installed it also drives a real fzf for n, y, q, Enter with --default=false, and Enter under FZF_DEFAULT_OPTS=--tac.

@omarchybot omarchybot added the enhancement New feature or request label Sep 27, 2026
@llstrk

llstrk commented Sep 27, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Follow-up on 313900a. The four behaviour issues from the earlier review are fixed, as described in the author's reply. The same commit introduced a file-mode change that breaks the helper in a checkout, a lint failure in test/shell, and a narrower keyboard race. The branch also now conflicts with quattro.

Verified with real fzf 0.74.3 in a pseudo-terminal, on an executable copy of the helper (see the first finding below):

Earlier finding Status at 313900a
n then Enter answered Yes Resolved: y/Y return 0; n/N/q return 1; Right, Left or Tab then Enter returns 1; Esc and Ctrl-C return 130
fzf not a package dependency, all failures mapped to 130 Resolved through the fallback: with fzf missing, gum confirm answers with the same labels and default; an invalid fzf option exits 2 with fzf failed (exit 2)
--default=false usually started on Yes Resolved: Enter answered No in 60 of 60 runs (previous helper: Yes in 25 of 30 and 23 of 30)
FZF_DEFAULT_OPTS changed the answer Resolved: --tac, --print-query, an options file and --no-mouse no longer change the answer or mouse reporting

The new real-fzf test block catches most of the earlier test gaps: it fails on --info=bogus, on a removed unset, and on a start:pos mutant in 9 of 10 runs. The stub runs still read the runner's own $HOME theme file.

bin/omarchy-confirm lost its executable bit

313900a changes the file mode from 100755 to 100644. In a checkout:

test/shell.d/confirm-test.sh   line 54: bin/omarchy-confirm: Permission denied   (exit 126)
omarchy confirm --help         Unknown Omarchy command   (exit 127; bin/omarchy registers only executable files)
omarchy-update-confirm         Permission denied, then "Update cancelled" without waiting for input
omarchy-update-restart         Permission denied, reboot offer skipped

The last two rows are with the checkout's bin/ first on PATH, as omarchy dev link sets it. With chmod 755, the PR's test passes in full.

Impact: packaged installs are not affected, because the PKGBUILD installs every bin/* with install -Dm755. In a dev-linked checkout without another omarchy-confirm on PATH, an update cannot be confirmed. When an executable copy exists later on PATH, for example from the package, bash runs that copy instead. The new test fails either way.

Suggested change: git update-index --chmod=+x bin/omarchy-confirm.

The new fzf check fails the bin style test

The fallback uses if ! command -v fzf. test/shell.d/bin-style-test.sh (lines 7-10) fails "bin commands use command helpers" for any file in bin/ containing command -v, except omarchy-cmd-*, omarchy-pkg-* and omarchy-upgrade-to-quattro. A sandboxed run of that test exited 1 and listed bin/omarchy-confirm. The check scans every file in bin/, so restoring the executable bit does not change this.

Impact: test/shell fails on this branch independently of the mode problem.

Suggested change: use the repository's helper, if ! omarchy-cmd-present fzf; then, and adjust the test to match. Its fallback case sets PATH to a directory holding only gum and awk, so omarchy-cmd-present would be missing there too and the gum path would be taken for the wrong reason (with an fzf stub added to that directory, the changed helper still ran gum). Linking $ROOT/bin/omarchy-cmd-present into that directory, and putting $ROOT/bin on the PATH of run_confirm and the Python block, keeps the test from depending on an installed copy.

Keys typed before the prompt appears can pick the wrong answer

fzf reads keys already pending at startup and can handle them before both rows have loaded (per fzf's source). pos(2) then lands on the only row present (Yes), and accept with no row exits 1. Key written to the terminal before the helper started, 100 runs per key:

Key Head Head with --sync gum confirm (20 runs)
n Yes in 4 all correct all correct
q Yes in 3 all correct all correct
y No in 73, each with fzf failed (exit 1) all correct all correct

Impact: only affects a key typed before the prompt appears, for example n pressed while the "Ready to update?" box is being drawn. In the runs above, where the key was already typed before the helper started, n or q started the update or reboot in 3 to 4 percent of cases. Keys pressed after the rows are drawn behave correctly, and gum confirm had no such race.

Suggested change: add --sync to fzf_args, so fzf starts only after the input and load actions have completed. With it, the key, mouse, default-row and fallback checks gave the same results as without it. An earlier 60-run sample with --sync had one miss (y answered No).

Conflict with current quattro

GitHub reports a merge conflict between this branch and quattro. bin/omarchy-update-restart conflicts because #9467 (merged 2026-09-25) added an unattended guard to confirm_reboot:

confirm_reboot() {
  if [[ ${OMARCHY_UPDATE_UNATTENDED:-0} == "1" ]]; then
    echo "$1 Run omarchy-system-reboot when ready."
  elif omarchy-confirm "$1"; then   # this PR's change, applied to the quattro version
    omarchy-system-reboot
    exit 0
  fi
}

Impact: taking this PR's version of the function as is would drop the unattended guard, so omarchy update -y would prompt whenever a reboot is due.

Suggested change: resolve as above. On a local merge with the executable bit restored, the PR test passed, --reboot-only rebooted (stubbed) on y and not on n, and the unattended path printed the message without prompting. quattro now also has a skip test helper, which fits pass "real fzf keyboard check skipped" better after a rebase.

Optional: gum also toggles with h, l and Shift-Tab. These are unbound here, so l then Enter answers Yes, while gum's source toggles to No on l (the highlight does not move). Binding them, for example h:up,l:down,btab:up (not tested), would match gum. The comment above the status check says Esc gives 130 like gum, but gum 2.x exits 1 on Esc (only Ctrl-C gives 130). Callers treat both the same.

Optional test improvement: the real-fzf block waits with os.waitpid(pid, 0) and no timeout. Run against the previous helper, or with the y/n/q binds removed, it hangs until killed (60 s in these runs) instead of reporting not ok. A deadline loop with os.WNOHANG that kills the child on expiry (not tested) should make it fail cleanly.


Review information

Test scope: follow-up at 313900a against the earlier findings, plus the new commit and its interaction with current quattro. Source review of the diff and callers, gum 2.0.2 and fzf 0.74.4 source, and the omarchy-pkgs PKGBUILDs. Sandboxed pseudo-terminal runs used real fzf 0.74.3 and gum 2.0.0 with scripted keys, synthetic mouse reports and a synthetic home directory. Reboot and shell restart were stubbed, and behaviour tests used an executable copy of the helper, with the committed mode tested separately. omarchy update was not run, no live terminal was clicked through, and the typeahead rate on a real terminal was not measured.

AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

z23 added 3 commits September 28, 2026 10:08
Keep quattro's unattended reboot guard and ask through omarchy-confirm,
so omarchy update -y does not start prompting again.
Restore the executable bit, probe fzf with omarchy-cmd-present, and start
fzf with --sync so a key typed while the prompt opens cannot accept the
wrong row. h, l, and Shift-Tab toggle like gum.
@z23

z23 commented Sep 28, 2026 •

Copy link
Copy Markdown
Author

Thanks for rechecking 313900a. The four earlier behaviour fixes stay. Taken in 74d00fd, on top of the quattro merge:

  • Restored the executable bit on bin/omarchy-confirm.
  • The fzf probe is omarchy-cmd-present, so test/shell no longer fails the command-helper check. The fallback test links that helper into its private PATH. Without the link, a missing helper took the gum path for the wrong reason.
  • Added --sync, and h / l / Shift-Tab, matching gum. The real fzf run covers l then Enter.
  • Merged current quattro. confirm_reboot keeps the unattended guard and calls omarchy-confirm, so omarchy update -y does not start prompting. The phase test stubs omarchy-confirm instead of gum.
  • The real-fzf block gives up after 8 seconds instead of waiting on waitpid. It uses skip when fzf or python3 is missing.

Two suggestions I did not take:

  • Esc still returns 130. fzf uses 130 for Esc and Ctrl-C. gum 2.x exits 1 on Esc and 130 only on Ctrl-C; the comment now says that. Callers treat both as cancel, and any other status stays a real fzf failure, which was the point of the previous fix.
  • No CI case types the key before the prompt exists. Your --sync sample still had one miss in 60, so that case would flake. --sync is in, and the existing run covers keys once both rows are up.

@llstrk

llstrk commented Sep 29, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Outcome: At 6bf9de7, the previous review's findings are resolved, except that Enter and toggle keys pressed while fzf opens can still answer Yes.

--sync does not cover Enter or toggle keys pressed while fzf opens

y/n/q typed early now answer correctly (0 wrong in 500 runs here). Enter and toggle keys act on the current row, and fzf can handle them before load:pos(...) runs: Enter on --default=false answered Yes in 54 of 100 runs, l then Enter in 40 of 100. Impact: both callers default to Yes, so only a blind toggle and Enter in the milliseconds before the rows draw can start the update or reboot.

Suggested change: keep --sync, bind start:pos($start_pos) instead of load:pos(...), and update the two test greps and the comment above fzf_args.

Reproducer (fails at 6bf9de7)

Reviewed head: 6bf9de7 (fzf 0.74.3, bash 5.3, Python 3.14).

The test below follows the style of test/shell.d/confirm-test.sh. It sends the keys the
moment fzf writes its cursor-position query (ESC [ 6 n). fzf writes that query right after it
switches the terminal to raw mode, before it draws the two rows. Each case runs 20 times.

Save it as test/shell.d/confirm-startup-keys-test.sh and run bash test/shell.d/confirm-startup-keys-test.sh.

#!/bin/bash

set -euo pipefail

source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"

# Keys that reach fzf after it has taken the terminal but before the rows are
# drawn. fzf writes its cursor-position query (ESC [ 6 n) right after switching
# the terminal to raw mode, so the keys are sent the moment that query appears.
if ! command -v fzf >/dev/null || ! command -v python3 >/dev/null; then
  skip "real fzf startup key check skipped"
  exit 0
fi

python3 - "$ROOT/bin/omarchy-confirm" <<'PY'
import os, pty, select, signal, sys, time

script = sys.argv[1]

def run(keys, args):
    pid, fd = pty.fork()
    if pid == 0:
        env = os.environ.copy()
        env.pop("OMARCHY_PATH", None)
        env.pop("FZF_DEFAULT_OPTS", None)
        env.pop("FZF_DEFAULT_OPTS_FILE", None)
        env["PATH"] = os.path.dirname(script) + os.pathsep + env.get("PATH", "")
        os.execvpe(script, [script, *args], env)
    out = b""
    sent = False
    deadline = time.time() + 8
    try:
        while True:
            ready, _, _ = select.select([fd], [], [], 0.01)
            if ready:
                try:
                    out += os.read(fd, 4096)
                except OSError:
                    pass
                if not sent and b"\x1b[6n" in out:
                    os.write(fd, keys)
                    sent = True
            wpid, status = os.waitpid(pid, os.WNOHANG)
            if wpid != 0:
                return os.waitstatus_to_exitcode(status)
            if time.time() > deadline:
                os.kill(pid, signal.SIGTERM)
                os.waitpid(pid, 0)
                return 124
    finally:
        os.close(fd)

cases = [
    (b"\r", ["--default=false", "Remove?"], 1),
    (b"l\r", ["Continue?"], 1),
    (b"n", ["Continue?"], 1),
    (b"y", ["Continue?"], 0),
]
failed = False
for keys, args, expect in cases:
    results = [run(keys, args) for _ in range(20)]
    wrong = [rc for rc in results if rc != expect]
    if wrong:
        print(f"not ok - startup keys={keys!r} args={args}: {len(wrong)} of 20 runs returned {sorted(set(wrong))}, expected {expect}", file=sys.stderr)
        failed = True
    else:
        print(f"ok - startup keys={keys!r} args={args}: 20 of 20 runs returned {expect}")
sys.exit(1 if failed else 0)
PY
pass "confirm answers keys typed while the prompt opens"

Actual output at 6bf9de7 (exit status 1)

not ok - startup keys=b'\r' args=['--default=false', 'Remove?']: 6 of 20 runs returned [0], expected 1
not ok - startup keys=b'l\r' args=['Continue?']: 5 of 20 runs returned [0], expected 1
ok - startup keys=b'n' args=['Continue?']: 20 of 20 runs returned 1
ok - startup keys=b'y' args=['Continue?']: 20 of 20 runs returned 0

A return of 0 is Yes: Enter on a --default=false prompt, and l then Enter on a default
prompt, answered Yes where gum confirm would answer No (by its source; gum was not run with keys in this window).

Same test with --bind "start:pos($start_pos)" in place of --bind "load:pos($start_pos)" (exit status 0)

ok - startup keys=b'\r' args=['--default=false', 'Remove?']: 20 of 20 runs returned 1
ok - startup keys=b'l\r' args=['Continue?']: 20 of 20 runs returned 1
ok - startup keys=b'n' args=['Continue?']: 20 of 20 runs returned 1
ok - startup keys=b'y' args=['Continue?']: 20 of 20 runs returned 0
ok - confirm answers keys typed while the prompt opens
Details
Earlier finding Status at 6bf9de7
bin/omarchy-confirm not executable Resolved: mode 100755, PR test passes
command -v failed the bin style test Resolved: bin-style-test.sh passes (fails at 313900a)
Keys typed before the prompt appears Resolved for y/n/q; Enter and toggle keys remain (above)
Conflict with quattro Resolved: confirm_reboot keeps the unattended guard; phase test passes on a merge with current quattro
Optional: h/l/Shift-Tab, Esc comment Resolved: bound, and the comment matches gum 2.0.2 source
Optional: real-fzf block had no timeout Resolved: a mutant that ignores y/n/q now fails with rc=124 instead of hanging

Verified (the first review's fixes still hold at this head):

  • y/n/q, h, l, Right and Shift-Tab after the rows draw
  • Enter on --default=false after the rows draw answers No
  • gum fallback when fzf is missing
  • FZF_DEFAULT_OPTS and FZF_DEFAULT_OPTS_FILE no longer change the answer
  • mouse clicks on Yes and No return 0 and 1 with --sync

Mechanism (fzf 0.74.3 source): --sync delays the finder until the input is read, but with no start action bound the key reader starts at once, and the main loop takes whichever of the key and load events is ready first. With a start action bound, fzf holds keys until the start actions have run, and fzf's manual says the list is available to start with --sync (0 misses in 700 runs here). With that change, keys sent as fzf takes the terminal answered correctly in every run (100 per case, 50 for Enter on the default prompt), and the PR's confirm-test.sh and bin-style-test.sh pass with the two greps updated. Keys typed before fzf takes the terminal are safe: Enter does not answer, and y/n/q answer correctly.

Optional note: docs/update-process.md (line 294) still describes omarchy-update-confirm as "Gum confirmation copy" and has no row for omarchy-confirm; updating it keeps the update-flow reference accurate about fzf with the gum fallback.


Review information

Test scope: Source and sandboxed pseudo-terminal runs (fzf 0.74.3, gum 2.0.0) at 6bf9de7 and on current quattro; no live terminal or omarchy update.

AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

@z23

z23 commented Oct 1, 2026

Copy link
Copy Markdown
Author

@llstrk Thanks for narrowing this to Enter and toggle keys during startup. I reproduced it: at the previous head, early Enter on a No-default prompt answered Yes in 5 of 20 trials, and early l plus Enter did so in 6 of 20.

Taken in ed6c5f0: the prompt keeps --sync and uses start:pos($start_pos). The comment and both assertions now describe selecting the default before reading keys. I added your startup reproducer as a regression with bounded waits; all four cases pass 20/20 trials. The existing prompt/fallback and restart-phase tests also pass.

I also updated docs/update-process.md and the PR description to describe the fzf helper and gum fallback accurately. Style, syntax, diff, and CLI metadata checks pass. The broader CLI suite stops at a pre-existing VS Code symlink assertion. Testing used pseudo-terminals; no live update or reboot was started.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds mouse support to update confirmation prompts.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR adds a mouse-capable confirmation helper for update and reboot prompts, with a gum fallback. Since the previous review, it rejects ambiguous labels, adds a real-fzf mouse test, and sizes the startup-key test’s PTY. No new actionable issue was established.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Update or reboot prompt] --> B[omarchy-confirm]
  B --> C{fzf available?}
  C -->|Yes| D[Inline mouse and keyboard choices]
  C -->|No| E[gum confirm fallback]
  D --> F[Confirm or cancel status]
  E --> F
Loading

Reviews (2) · Last reviewed commit: "Reject ambiguous confirmation labels and..."

Comment thread bin/omarchy-confirm Resolved
Comment thread test/shell.d/confirm-test.sh Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gum confirm prompts are keyboard-only, so a GUI-initiated omarchy update can't be answered with the mouse

3 participants