Repository navigation
Conversation
A hard device error (as opposed to a completed no-match) retried at the same flat 250ms interval as a genuine no-match. Some readers, including the Goodix GXFP5130, trip their thermal cutoff when polled this fast through a run of consecutive errors rather than an actual touch, which then locks fingerprint auth out entirely (lock screen and PAM alike) until the sensor is manually reset. Hard errors now back off exponentially (2s, capped at 30s); a genuine no-match still retries at the fast base interval and resets the backoff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LonAaqr1pXKCGe9zmfXFB1
Automated AI review
The backoff in this PR does not take effect with any released Quickshell version. After a hard fingerprint error the lock screen still retries after 250 ms, the same as the base branch. No regression was found: runtime behavior matches the base branch. The completion handler overwrites the error backoffQuickshell's Impact: The 2 s doubling to 30 s never happens, so the retry storm described in the PR is not reduced. Suggested change: Make the split inside A working backoff would also delay fingerprint unlock on an idle lock screenOmarchy writes the lock PAM file as a bare
Impact: If the first finding is fixed by backing off on every Suggested change: Back off only on fast failures. For example, record the start time in Optional test improvement: Neither test in the PR's test plan reaches the changed code. Verified: The PR leaves password authentication, fingerprint success and unlock, and timer stop and PAM abort on reset unchanged. The fingerprint indicator is unaffected. The PR also applies to the current Review informationTest scope: Source review of the PR head, its merge-base and the current AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments with targeted follow-up questions, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
Reviewed by Claude Opus 5.5 and run on an Omarchy ISO worker, with a second opinion from Codex at medium effort. The retry storm you describe is real, but this change doesn't slow it down: after a hard error the lock screen still retries 250 ms later, the same as Why. Quickshell's Reproduced on the worker. I spliced the Fixing the order alone would not be enough. A competing fix already covers this. #11918 schedules the retry only from the completion, and it backs off only on attempts that fail within a second. A wrong finger or a timeout still retries at 250 ms. It has been verified on a worker and is labelled Neither review could test a real GXFP5130. Whether the sensor recovers sooner under a backoff depends on hardware a worker doesn't have. This now waits on the maintainer, who chooses between the competing fixes. |
|
Thank you for this, @thabopal. #11918 fixes the same problem in a way the review judged better, so this is closed in favour of it. If it does not cover your case, please say so there. Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent. |
|
The replacement error-backoff fix is now shipped in merged #7158, including fast errors after the finger prompt. #11918 is being closed as superseded; this alternative remains closed. GPT-6 in Codex and Claude Opus 5.5 Medium checked the coverage against the landed source; Claude's agreement does not guarantee independence. This closure review was read-only and did not rerun runtime tests. |
Summary
shell/plugins/lock/Service.qml) retried at a flat 250ms on anyfingerprintPam.onError, the same interval used for a genuine completed-no-match.Device disabled to prevent overheating, logged byfprintd), which then locks out fingerprint auth entirely — lock screen and PAM (sudo, polkit) alike — until the device is manually reset (gxfp_recovery --reset-mcu --reset-sensor).onErrorpath, while a genuine no-match completion still retries at the fast 250ms base and resets the backoff.Test plan
test/shell.d/lock-fingerprint-indicator-test.sh— passestest/shell.d/lock-blank-fingerprint-test.sh— passestest/allsuite not run (scoped change, targeted tests above cover the touched behavior)Disclosure
This fix was diagnosed and written by Claude (Sonnet 5, via Claude Code) working on the reporter's machine, from a live reproduction:
journalctl -u fprintd.serviceshowed a continuous ~1-2s stream ofDevice disabled to prevent overheatingcorrelating with a lock-screen retry storm, andService.qml's mtime matched theomarchy4.0.4-1 package (installed 2026-09-16), which had silently reverted an earlier local patch doing the same thing.🤖 Generated with Claude Code