Skip to content

Fix empty-desktop bar reposition handoff (#11915) - #12643

Closed
paulogeyer wants to merge 3 commits into
omacom:quattrofrom
paulogeyer:fix/11915-empty-bar-handoff
Closed

paulogeyer wants to merge 3 commits into
omacom:quattrofrom
paulogeyer:fix/11915-empty-bar-handoff

Conversation

@paulogeyer

Copy link
Copy Markdown
Contributor

Summary

  • Empty-desktop bar edge-drag still failed with #12184 alone (windowed PASS / empty FAIL on my laptop).
  • This draft builds on that PR’s eligibility + overlay handoff and fixes the empty-desktop path while keeping release-to-commit UX (hold once, sweep multiple edges, mouse-up docks — no auto-dock on hover).

Fixes

  1. Strip onReleased guard — grab-steal during handoff must not call finishBarMove() while the candidate is still the current edge.
  2. Item-backed overlay mask — Quickshell needs Region { item: … }; bare width/height did not receive motion after handoff.
  3. Handoff-pending — ignore synthetic buttons=0 right after grab cancel; finish on a real overlay left release (or strip release when not handed off).
  4. Deferred takeBarMovePointer via Qt.callLater so press-and-hold is not racing a synchronous grab-steal.

Test plan

  • bash test/shell.d/bar-test.sh → 116 ok (includes new handoff/mask/Released asserts)
  • Live empty workspace: center press-and-hold → drag across edges while held → release to dock
  • Live with a window open: same gesture (no regression)
  • Escape / secondary click still abort a stuck ghost

Fixes #11915

Related: #12184 (prefer merging or closing in favor of this once reviewed — happy to rebase/coordinate with @thescurry).

cursoragent and others added 3 commits September 16, 2026 17:56
The move gesture died with zero mapped clients because leaving the bar
strip handed the pointer to the wallpaper and cancelled the grab.
Eligibility no longer depends on toplevels, and a lost grab is handed
to the move overlay so the edge preview can finish the drag.

Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Taking the pointer after a lost grab never armed the overlay, so a
still release at the strip edge left the ghost mapped. Handoff now
arms, a poll finishes a motionless button-up, and Escape, a secondary
click, or a short timeout abort the same stuck state.

Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Builds on omacom#12184. After wallpaper grab-cancel, guard strip Released so it
cannot finish/clear early, use an item-backed overlay mask for input, ignore
synthetic buttons=0 while handoff-pending, and keep release-to-commit UX.

Fixes omacom#11915
@paulogeyer

Copy link
Copy Markdown
Contributor Author

Closing for now — will re-open after local empty-desktop soak/analysis. Sorry for the premature draft.

@paulogeyer paulogeyer closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging the bar only works when there is at least 1 window (broken on empty desktop)

2 participants