Repository navigation
Fix empty-desktop bar reposition handoff (#11915) - #12643
Closed
paulogeyer wants to merge 3 commits into
Closed
paulogeyer wants to merge 3 commits into
paulogeyer wants to merge 3 commits into
Conversation
The move gesture died with zero mapped clients because leaving the bar strip handed the pointer to the wallpaper and cancelled the grab. Eligibility no longer depends on toplevels, and a lost grab is handed to the move overlay so the edge preview can finish the drag. Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Taking the pointer after a lost grab never armed the overlay, so a still release at the strip edge left the ghost mapped. Handoff now arms, a poll finishes a motionless button-up, and Escape, a secondary click, or a short timeout abort the same stuck state. Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Builds on omacom#12184. After wallpaper grab-cancel, guard strip Released so it cannot finish/clear early, use an item-backed overlay mask for input, ignore synthetic buttons=0 while handoff-pending, and keep release-to-commit UX. Fixes omacom#11915
Contributor
Author
|
Closing for now — will re-open after local empty-desktop soak/analysis. Sorry for the premature draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
onReleasedguard — grab-steal during handoff must not callfinishBarMove()while the candidate is still the current edge.mask— Quickshell needsRegion { item: … }; bare width/height did not receive motion after handoff.buttons=0right after grab cancel; finish on a real overlay left release (or strip release when not handed off).takeBarMovePointerviaQt.callLaterso press-and-hold is not racing a synchronous grab-steal.Test plan
bash test/shell.d/bar-test.sh→ 116 ok (includes new handoff/mask/Released asserts)Fixes #11915
Related: #12184 (prefer merging or closing in favor of this once reviewed — happy to rebase/coordinate with @thescurry).