Repository navigation
Conversation
6 tasks done
Author
|
Closing as a duplicate of #8560, which directly addresses the same lock-screen password focus loss after suspend using the same small, event-driven focus recovery approach. Our branch also explored a behavioral test fixture for the regression. #9181 is a broader resume-recovery proposal, but #8560 is the closest match for this specific bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
This is a narrow, event-driven alternative for the case where an already-active lock window loses its focus item. It intentionally does not add the explicit resume IPC, retry budget, or post-PAM recovery implemented by #9181, so it remains a draft while that overlap is resolved.
Related: #12525, #9180, #9418, #9181.
Summary
LockView.Root cause
The lock surface can stay mounted while displays are blanked and the machine suspends. The existing focus requests only run when the component is created or input is enabled, so neither necessarily runs when an existing lock window becomes active again or loses its active focus item.
Test plan
origin/quattrowithpassword input did not reclaim focus.test/shell.d/lock-focus-test.shgit diff --checkbash -n test/shell.d/lock-focus-test.sh./test/allexecuted; the new lock-focus test passes.The full local suite reports 9 unrelated baseline/environment failures in
config-test,factory-reset-accounts-test,launch-about-test,locate-test,network-qr-test,omarchy-kernel-migration-test,snapper-test,unowned-system-paths-test, andupdate-pacman-test. None of those files or their production paths are changed by this branch.The regression harness is 100 lines, down from 213 in the first draft, and no longer requires a live compositor,
jq, result files, or layer-shell setup.No before/after media is attached yet. Keyboard focus is verified behaviorally by stealing focus from the real password input and confirming that it returns without a pointer click.