Repository navigation
[Intel Mac P07] Preserve the MacBook8,1 SPI PIO workaround - #12685
Draft
andrew-boyd wants to merge 6 commits into
Draft
andrew-boyd wants to merge 6 commits into
andrew-boyd wants to merge 6 commits into
Conversation
Consolidate existing source contributions for draft review. Original implementation authors are retained as author/co-authors; the committer assembled and reconciled the candidate. No contributor approval or sign-off is implied. Known defects and excluded alternatives remain documented in the PR body. Source-PR: omacom#9735 Source-Commit: omacom#9735abba2c4
|
I confirmed three configuration-handling cases in
The latter two cases can receive the completion marker after rebuilding without establishing the intended configuration. These limitations are already disclosed in the draft; the fixtures confirm them. Before automatic rollout, the migration should preserve unrelated parameters and verify both required settings in the effective configuration before marking completion. The existing tests cover idempotence and rebuild retry, but not these three cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Intel Mac P07] Preserve the MacBook8,1 SPI PIO workaround
Consolidate the existing MacBook8,1 PIO/s2idle contribution. Follow-up software repairs preserve custom configuration, append SPI modules to the base list, require the complete shipped boot-parameter pair, and keep failed rebuilds retryable. The hardware parameters are unchanged.
Draft consolidation for source review and hardware-owner follow-up. Known defects remain; no hardware or merge-readiness certification is claimed. Part of the 14-feature Intel Mac series with three package companions.
Contribute: open follow-up PRs in
andrew-boyd/omarchywith baseintel-mac/p07-spi-pio. Use[Intel Mac P07]in the title and a contributor branch such asintel-mac/p07/describe-change. Link this feature in the series index. Merging a follow-up into this branch updates its roll-up.This existing draft: #12685.
Full Intel Mac scope and current revision
The project covers all 64-bit Intel Macs: pre-T1, T1 and T2. MacBookPro13,3 is only the first available physical test machine. Each feature has its own hardware boundary; one model's success does not validate the rest.
Candidate head:
612908e346bfdacd31bd0d70d27955d73803f52e; reconciled upstream:8f324c90b82790d31ab33565441e07cbdb8d2308. Published contribution commits and author/co-author metadata remain in the history.Ready for attended physical testing; Mac hardware remains untested by this effort. The reconciled combined ISO passed fresh unencrypted/encrypted VM installations, desktop/password-lock checks, strict Neovim startup/theme checks, synthetic Apple EFI preservation through a disk wipe, and affected package/DKMS/migration checks. ISO SHA-256:
9e6288ef5cc1eadce519cdd7384c8030286eb938a6288eb218f025a61b433252.Exact sources, results, retained failures and reproduction. These results cover the pinned combined image; standalone-versus-combined differences remain explicit. Full inventory and retained work tracks.
Scope and dependencies
Preserve the source MacBook8,1 SPI-PIO parameters and administrator configuration. Coordinate package ownership with P06; no new timing or electrical workaround is invented.
The inventory now records 188 source/context PRs: 101 have dispositions in feature tables and 87 remain only in separate work tracks. This is not 188 implemented PRs or 188-to-14 compression. The 14 feature PRs and three package companions remain the published coordination targets; retained backlog is not claimed complete.
Every affected source PR and recommended action
Current open/closed/merged state is administrative history, not proof that two patches preserve identical behavior. Included/partial identifies selected contributions; alternatives, deferred work and context are not automatically ISO content.
Validation and attribution
Required fresh-image checks are satisfied, with qualified reruns. The full source suite passed 273 files with two disclosed skips, but repeated NetworkManager Polkit failures during that suite temporarily locked its test account. The following password/desktop/recovery checks failed there and passed separately in a clean overlay of the same ISO; the original aggregate remains failed. The first build attempt also failed one libfprint USB-emulation test; unchanged-source isolated repeats, two complete suites and normal package checks passed afterward. That intermittent build-test failure remains documented, and its cause is not established. VM fixtures and DKMS builds do not establish physical device behavior. Physical Wi-Fi, audio, camera, Touch Bar, fingerprint, graphics and suspend behavior remain unverified by this effort.
Original source histories remain linked above. Source-authored commits already included in the roll-ups remain ancestors of this revision; additional copied contributions receive native attribution. Original attribution mapping. No original PR is edited or closed by this effort.