Repository navigation
Require a per-session token before honoring notification click-exec - #12713
Closed
chessing234 wants to merge 1 commit into
Closed
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
Sandboxed same-uid bus clients can forge omarchy-exec-argv; mint a token under XDG_RUNTIME_DIR that only host helpers can read, and ignore click commands whose omarchy-exec-token does not match. Closes omacom#8433.
Contributor
Author
|
closing — already covered in #12111. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$XDG_RUNTIME_DIR/omarchy/notification-exec-token(0600) when the notifications service starts.omarchy-notification-send --execattaches that value asomarchy-exec-token; the shell only keepsomarchy-exec-argvwhen the tokens match.Closes #8433.
Test plan
bash test/shell.d/notifications-test.shbash test/shell.d/notification-send-test.shomarchy-notification-send "t" --exec truestill produces a clickable toastomarchy-exec-argv(no token) does not run a command on click