Repository navigation
Conversation
|
Verified: At
Remaining pre-existing nounset failure in update-status
Impact: The missing environment variable is treated like “no updates available” without checking updates. This is a pre-existing, non-fatal condition failure, not a regression introduced by the PR. The helper failure and branch selection were reproduced; the full update and actual shell indicator were not exercised. Suggested change: Apply the same Optional test improvement: In Review informationTest scope: Targeted shell tests and baseline/head helper execution with synthetic Git, package and channel dependencies, including explicit package/dev paths. No real sudo/cron invocation, package upgrade, Git remote, desktop indicator, full update or full test suite was exercised. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra initial source inspection, independent Fable 5.1 High and Astra Xhigh technical reviews, followed by Astra synthesis against source and targeted execution evidence. |
|
Both done in 4a00459. omarchy-update-available got the same fallback plus a regression test, and the env -i call in update-dev-test now forwards TEST_GIT_LOG so a git call on that path cannot hide from the assertion. |
|
Verified by source inspection: Both points from the earlier review are addressed at
The added Review informationTest scope: Conclusions are based on pinned source and test-code inspection, not runtime validation. This follow-up does not establish full updater behavior, real package or Git operations, sudo/cron execution, or the desktop update indicator. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra initial inspection, independent Opus 5.5 High and GPT 6 Sol Xhigh technical reviews, followed by Astra synthesis against the pinned source. |
|
I reviewed this at 4a00459, merged onto current What ran on the worker
Why it no longer fixes #12858 on
The other callers all run with For the maintainer
Who checked it: Claude Opus 5.5. No second opinion: the configured reviewer, Codex Medium, answered the availability check, but omabot's daily review allowance was used up, so no second model checked this review. No |
|
I think this needs a rule decision before it needs more review, so I'd rather ask than keep it in the queue as "verified, waiting". The change does what it says. With But it no longer fixes #12858 on And it cuts against a stated rule. The question: should Either answer settles five PRs that currently depend on it: this one, #8590 ( |
|
Re-checked at 4a00459, merged onto current Same result on current What is new
Second opinion: Codex Medium reviewed the merged tree and found no defect in the three guards. It agreed that no shipped caller reaches them with This still waits on the maintainer's answer to the question above: should |
Reported as #12858, which was closed as a duplicate of #8239. This does not resolve
#8239 —
omarchy updatewithOMARCHY_PATHunset still stops at the entry check —so it references the report rather than closing it.
Problem
omarchy updateaborts from stripped environments (sudo, cron/timer, non-bash shells) withomarchy-update-dev: line 7: OMARCHY_PATH: unbound variable. The script runs underset -euo pipefailand compares the bare variable, with no fallback to the packaged default.Change
bin/omarchy-update-dev:[[ ${OMARCHY_PATH:-/usr/share/omarchy} != ... ]], matching the issue's suggested fix and theenv-bootstrapprecedent — unset means package-backed, so it exits 0 before touching git.bin/omarchy-channel-current: same one-line shape at line 10, same crash underenv -i(verified before the fix). Included since it is the identical defect in the neighboring command rather than a separate issue.test/shell.d/update-dev-test.sh,test/shell.d/channel-test.sh:env -iregression tests asserting clean exit, no git invocation (update-dev), correct channel resolution, and no "unbound variable" output.Verification
./test/all: CLI suite fully green; shell suite shows only the 5 pre-existing environment failures (missingomarchy-pkgscheckout,omasnap, Qt portal) — confirmed identical on the clean tree