Repository navigation
Conversation
|
Verified: No actionable defect found in the reviewed scope at
With the real helper inside a stubbed The successful control continues through the remaining update steps. Review informationTest scope: Source review and isolated execution of the actual helper and parent scripts with package, network-check and session operations stubbed. No real package transaction, inhibitor operation, lock acquisition or terminal interrupt was tested; 130 is a simulated exit status. The parent's terminal-recording wrapper was bypassed. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection, independent Opus 5.5 High and GPT 6 Sol Xhigh technical assessments, followed by Astra synthesis and verification against targeted evidence. |
|
Thanks for this. The bug was real on What is left here is preserving yay's exact status (42 or 130 rather than 1) plus the new tests, and the branch now conflicts with What was checked: this was read, not run. I compared the diff against current Next: this is with the maintainer, with the recommendation that it be closed as already fixed on |
When
yay -Suafails or is interrupted,omarchy-update-aur-pkgscurrently runs its trailingechoand returns success. The parent update then continues through its remaining steps instead of reporting the failed AUR transaction.Enable
set -ein the helper so it preserves the failing exit status. No foreign packages and an unavailable AUR remain successful skips. Regression tests cover the helper and the real helper inside a stubbed full update, including stopping later steps and releasing the update inhibitor.Validation:
quattroat947e2fc0: the helper and parent update incorrectly succeed when theyaystub fails.bash test/shell.d/update-aur-test.shandbash test/shell.d/update-sequence-test.shpass, including exit statuses 1, 42, and 130../test/cli,bash test/shell.d/bin-style-test.sh, Bash syntax checks, andgit diff --checkpass.Package and session operations are stubbed in these tests; no real package transaction was run.