Repository navigation
test: resolve lua via command -p to avoid shim loops - #12928
chessing234 wants to merge 4 commits into
Conversation
|
Verified: No actionable defect found in the tested scope at For the missing-Voxtype invocation, using guarded synthetic shims:
The baseline test still reports success when its guarded shim fails, so the comparison checks actual Lua output rather than relying on its exit status alone. This is a pre-existing test limitation, not a regression introduced here. Review informationTest scope: The targeted Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection, independent Opus 5.5 High and Astra Xhigh technical reviews, followed by Astra Medium synthesis and verification against the saved source and targeted test evidence. |
|
thanks — nothing further on my side |
|
Reviewed at d4fcb21 and reproduced on an Omarchy worker VM. The bug is real and this fixes it. To reproduce it I put a mise/asdf-style The change follows the same pattern as #8268. One note: the stub-first assertion can never fail, because On "Closes #8742": the fork bomb that issue reports was fixed by #8268, and that test was retired in #12739. Closing it with this change, which fixes the last copy of the pattern, seems right. This was reviewed by Claude Opus 5.5 only. The second-opinion reviewer (Codex) did not run because its daily review budget was spent, so this has not had the independent review it needs before it can be marked ready. Nothing is needed from you; it is waiting on that second review and then on the maintainer. |
Resolves the conflict with omacom#14552, which replaced the Voxtype binding tests with backend-neutral dictation tests and reused the same missing_bin symlinks. The command -p resolution now feeds the dictation and Lazydocker cases that share that directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch had started conflicting with Re-verified at 8e29ad9 on an Omarchy worker VM, with the same mise/asdf-style Second opinion: Codex at medium effort reviewed the merged head this time and found nothing wrong with the change or the merge. It agreed that the Nothing is needed from you. This now waits on CI finishing on the new head, and then on the maintainer. |
[Low impact] The PR appears safe to merge; no blocking issues were found. SummaryUpdates
Reviews (2) · Last reviewed commit: "Drop the stub check that only tests comm..." · Reviewed by Greptile |
quattro now fails the dictation test when the restricted-PATH lua run exits non-zero; keep that alongside this branch's command -p -v resolution.
The decoy lua stub could never be selected, because command -p ignores PATH, so the assertion restated bash rather than testing the fix and ran against AGENTS.md's "Don't test your own stub". The three command -p -v links are the fix; the test already goes red without them when a shim is first on PATH.
|
This had started conflicting with
I re-verified 336b8cf on an Omarchy worker VM with a guarded mise/asdf-style
Reviewed by Claude Opus 5.5, with Codex at medium effort and muse-wonder at high effort as the second opinion. Neither found a defect in the change or the merge, and both agreed that removing the stub check is right. That agreement came after my own review, and its independence is not guaranteed. Both reviewers also pointed out that "Closes #8742" is broader than the fix. The fork bomb #8742 reports came from a test that was retired, and this PR fixes the lua copy of the same pattern. Two other tests still link Nothing more is needed from you. This is waiting on the maintainer. |
|
dropped the stub assertion from the description. the fix is the three |
|
@dhh ci is green and this is still mergeable. |
Summary
hyprland-default-config-test.sh:ln -s "$(command -v lua)"underPATH="$missing_bin"alone can re-enter a mise/asdf shim. Resolve withcommand -p -v(same approach as Avoid mise shim recursion in Copy URL migration test #8268).Closes #8742
Test plan
bash test/shell.d/hyprland-default-config-test.shon an Omarchy host (systemluaon POSIXPATH)