Repository navigation
Conversation
Peer omarchy-hw-* and update helpers ship as 100755; source heads omacom#11023/omacom#11025 created these as 100644, which fails -x checks.
Source head used same_luks_members_show before defining it and left duplicated orphan fragments after the first suite. Define the extra-same fixture and drop the corrupted tail.
|
No important actionable production defect was found in the tested scope at Verified: The seven changed Install rows retain their installed-state dimming on x86_64 and are hidden for modeled aarch64/arm64 systems. Checks exercised the production menu model and generated guards with synthetic architecture and package-presence responses.
Verified: With synthetic storage responses, a distinct extra LUKS-backed Btrfs member produces the warning; single-member, plain-extra-member and same-LUKS-container cases remain silent. Root aliases and subvolume suffixes were covered. The production update-log analyzer preserves the warning without failing: Review informationTest scope: Targeted base/head menu and helper checks, update-log integration, and source inspection. No rendered desktop, native ARM installation, complete ARM package-availability audit, real multi-device Btrfs boot, or full repository suite. Storage detection used stubs; native enumeration permissions were not validated. The warning assumes the stock unlock setup and does not inspect a customized multi-device initramfs configuration. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra initial inspection, independent Opus 5.5 High and Astra Xhigh technical reviews, followed by Astra adjudication of the reports and targeted evidence. |
|
Verified against current quattro (fail-then-pass on scoped shell tests). Ready for maintainer review. Scoped: root-btrfs-extra-luks-test, hw-x86-64-test, menu-test. |
|
Thanks for re-cutting these. Two notes:
|
|
The Install gating here has gone stale on |
[Medium impact] The PR appears safe to merge; no outstanding blocking issues were found. SummaryAdds an advisory warning when root Btrfs spans separate LUKS-backed devices.
Reviews (3) · Last reviewed commit: "test(storage): exercise unencrypted Btrf..." · Reviewed by Greptile |
Summary
Re-cut of install/arch leftovers onto current
quattroafter #11501 closed unmerged.Cherry-picks unique hunks from:
omarchy-hw-x86-64Out of scope: #11024 (already closed). Shell/tray leftovers are a separate PR.
Why still needed
On
quattro@ d3cfd53 these paths were still absent:bin/omarchy-root-btrfs-extra-luksbin/omarchy-hw-x86-64default/omarchy/omarchy-menu.jsoncdrifted — conflict resolved here; Install rows stay gated by arch/prereq helpers only.Test plan
./test/shell—root-btrfs-extra-luks-test.sh(12/12),hw-x86-64-test.sh(3/3),menu-test.sh(incl. x86_64-only Install gates)Linear: PER-1528. Source heads: close #11023 #11025 as salvaged after this lands.