Skip to content

Keep a working libfprint fork during fingerprint setup - #12945

Closed
chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:fix/fingerprint-keep-libfprint-fork
Closed

chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:fix/fingerprint-keep-libfprint-fork

Conversation

@chessing234

@chessing234 chessing234 commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Detect a usable libfprint via pacman -Qq provides (libfprint / libfprint-2 / libfprint-git) so community forks are not treated as missing.
  • Only install libfprint-git when nothing usable is present (or only stock libfprint); never --ask 4 replace a provides-satisfying fork.
  • Restart fprintd after a package change so enroll/verify use the on-disk library, not a stale mapped .so.

Closes #11899

Test plan

  • ./test/shell.d/fingerprint-package-test.sh
    • fresh machine → installs libfprint-git
    • stock libfprint → replaced with libfprint-git
    • fork providing libfprint/libfprint-2 → left alone
    • already installed libfprint-git → no pacman touch

@chessing234
chessing234 force-pushed the fix/fingerprint-keep-libfprint-fork branch from bec9890 to f5480ef Compare September 22, 2026 20:25
@llstrk

llstrk commented Sep 22, 2026

Copy link
Copy Markdown

Verified: No important actionable issue found in the scoped review of f5480ef. With package operations stubbed, the actual setup script avoids requesting a driver replacement when a fork provides libfprint, while retaining the fresh-install and stock-replacement paths.

Synthetic installed state Baseline install request PR install request
Fork providing libfprint, plus fprintd and usbutils libfprint-git fprintd usbutils None
Same fork, missing fprintd libfprint-git fprintd usbutils fprintd only
Stock libfprint, plus both utilities libfprint-git fprintd usbutils libfprint-git only

The PR requests systemctl try-restart fprintd.service after a successful simulated package transaction, skips it on the no-install path, and stops before restart/enrollment when installation fails. Inspected pacman source supports the provides-aware query, including useful stdout when some query targets are missing.


Review information

Test scope: Source inspection and isolated baseline/head runs of the real setup script with synthetic package metadata and stubbed privileged commands. No real package transaction, service restart, fingerprint enrollment, hardware behavior, or PAM changes were tested.

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Automated AI review: Astra Medium initial inspection and synthesis, independent Opus 5.5 High and GPT 6 Sol Xhigh technical reviews, followed by verification of public claims against targeted evidence and a fresh Astra Medium editorial check.

@chessing234

Copy link
Copy Markdown
Contributor Author

folding into #12110 — keep-working-fork is already on that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy setup security fingerprint silently evicts a working libfprint fork, then "succeeds" against the stale daemon

2 participants