Repository navigation
Document the [bar] size keys - #13137
cristian-fleischer wants to merge 2 commits into
Conversation
Automated AI review
Verified: The parser change fixes the reported gap. Bar tokens with a synthetic user
Added test matches source text, not parser behaviorThe new assertion in
Impact: Test-only. A regression of this bug written differently would still pass, and an equivalent refactor would fail. Suggested change: Evaluate the real functions instead of matching text: extract Candidate assertion (replaces the new block in the
|
d6fa34d to
ab3fa9e
Compare
|
Thanks @llstrk, useful review. I took your harness almost as is: |
Automated AI review
Follow-up to the earlier review and the author's reply, checked at head
Verified (test):
The test fixes Verified (docs): The four keys are now in the "Bar size" block of Verified (production): Since the earlier reviewed head Optional documentation note: "width of one widget slot" ( Review informationTest scope: Source review of head AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
ab3fa9e to
fb78c59
Compare
|
Thanks @llstrk. Fixed the wording: |
|
Reviewed and reproduced on an Omarchy worker VM. The bug is real on current Reproduction. I wrote my own check rather than relying on the PR's test: a Tests. I merged this head onto Side effects. Other numeric Second opinion. Codex Medium reviewed the same diff and found no defects. It agreed on the side effects and on the test failing on the base. It also checked the documented defaults (27/16/13/21) and the "along the bar" wording against Related. #6587 makes the same parser change and came first. This PR adds a behavioural test and documentation for the four keys, and both reviews prefer it for that. Which one lands is the maintainer's call. This covers part 1 of #11359. The glyph-sizing half is still open, so this PR is not linked to close that issue. Waiting on the maintainer. |
|
This now conflicts with Same fix. Against current What this one adds. Your What was checked. Both diffs read against current Second opinion. Codex Medium was given both pull requests without my answer and came to the same choice. It added the two mutations above that #6587's test misses, and noted that the comment in the folded test should not claim every bar token goes through Waiting on the maintainer. |
fb78c59 to
318dd22
Compare
|
Rebased on quattro. 201de1c already lets these keys through the parser, so I dropped the code change and kept the docs and the parser test. I think the widget sizes are still worth documenting, but if you'd rather not take docs on their own, feel free to close this. #13138 and #13139 don't depend on it anymore. |
[Low impact] This documentation-only PR appears safe to merge. SummaryDocuments the five existing
Reviews (5) · Last reviewed commit: "Merge remote-tracking branch 'origin/qua..." · Reviewed by Greptile |
|
Re-read at Classification is unsettled. I read it as What was read. I checked the documented keys and defaults against Related. #6587 makes the parser change that Waiting on the maintainer, who decides whether docs and a test for existing keys are worth taking on their own. |
d04554d to
0b1af62
Compare
|
Re-read at
The test does not fail without this pull request. What checks out. The defaults (27/16/12/13/21) match the Classification is still unsettled. I read this as Who checked it. I (Claude Opus 5.5) read the diff against the code at this head. Codex Medium reviewed the same and raised both points above. I confirmed each one in the source. Codex could read this session's working notes, so its review is not guaranteed to be independent. Waiting on the maintainer, who decides whether to take documentation for existing keys on its own, and whether to take the test. The |
201de1c lets icon-slot, icon-canvas, icon-size, icon-font and status-slot through the [bar] parser, which fixes part 1 of omacom#11359. The keys are still missing from docs/omarchy-shell.md and the theme template. docs/omarchy-shell.md and shell.toml.tpl list the keys with their defaults; the Style.qml header names them. icon-font is the font size an icon button renders its glyph and label at; the drawn glyph is rescaled to fit icon-size, so it does not make the icon bigger. Co-Authored-By: Claude <noreply@anthropic.com>
0b1af62 to
f52df76
Compare
|
Thanks, both fixed in f52df76. |
|
Checked at
I reviewed this as GPT-6 in Codex (effort setting not exposed). Opus 5.5 High and muse-wonder via pi, thinking high, reviewed the same change and found no actionable defects. Their agreement is not guaranteed to be independent. Waiting on the maintainer. |
201de1c already lets the
[bar]size keys through theStyle.qmlparser, so this PR no longer changes code. What is left is the docs.docs/omarchy-shell.md, the theme template and theStyle.qmlheader listicon-slot,icon-canvas,icon-size,icon-fontandstatus-slotnext to the two bar sizes.icon-fontis described as what it does: the font size an icon button renders its glyph and label at. The drawn glyph is still rescaled to fiticon-size.The parser test is gone: it passed on quattro without this PR.
Part 1 of #11359 (thanks @fk1blow for the analysis). #6587 by @tmn73 made the same parser fix first; I missed it when I searched for duplicates.
#13138 and #13139 no longer depend on this PR.
Part of a set of opt-in bar changes described in #13136: #13137
[bar]size keys, #13138 floating, #13139 pills, #13140 bar options. Nothing changes unless you turn it on.Claude (Anthropic) wrote most of this under my supervision; I reviewed it and run it on my own Omarchy install.