Repository navigation
Sync root when updating the user password from the menu - #13215
chessing234 wants to merge 6 commits into
Conversation
Automated AI review
Verified: on a default Omarchy install, the change does what it describes. After two matching, non-empty prompts, Two behavior changes affect setups other than the default single owner: The menu row now always changes root, including a locked or unset root
Impact: using the password menu silently re-enables password login for root ( Accounts without sudo rights can no longer change their own password from the menu
Impact: a non-admin user loses the only password option in the menu, after typing the new password twice. Suggested change (covers both): keep a user-only path next to the combined one. For example, run plain Smaller notes
Review informationTest scope: source review of the PR and of the dependencies it relies on, at the versions Arch currently packages: shadow 4.20.0 ( AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
non-wheel falls back to passwd, locked root asks before syncing, cancel keeps 130, and the user group is listed |
Automated AI review
Follow-up to the earlier review and the author's reply, checked at Outcome: four of the five earlier findings are resolved. The new locked-root check, however, stops the password change for every account in
Verified: a non-wheel account now reaches plain The locked-root check makes the menu row fail for every wheel userCorrection to the earlier review: its suggested change said to check root with
The confirm prompt never appears, and neither password changes. The earlier head and the base both changed the password. Impact: on a default install, the User and root row asks for the new password twice and then fails with no explanation. If the error is simply tolerated instead (for example Suggested change: read the status through root_status=$(sudo passwd -S root | awk '{print $2}')The Ctrl+C at the new root confirmation still changes the user's passwordOnce the check above works, a locked ( Impact: cancelling at this prompt changes the login password instead of cancelling. Suggested change: in the Smaller notes
Review informationTest scope: source review of the new commit and the dependencies it relies on, at the versions Arch currently packages: shadow 4.20.0 ( AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
[Critical impact] The change reaches root password authentication through the password menu. Satisfy the indentation requirement before merging; no new behavior defect was found in the latest changes. Findings
SummaryThe password menu now updates the login and root passwords together, with safeguards for non-administrators and locked or empty root passwords.
Reviews (5) · Last reviewed commit: "fix: drop the redundant password example..." · Reviewed by Greptile |
|
fixed in 86b141d: root status is read through sudo, cancellation and prompt errors abort without changing either password, and the empty-root prompt now describes its actual state. eight stubbed checks pass, including denied status reads and cancellation; the native pam and desktop flow has not been run. |
|
FYI, #14556 (on the Small nit: |
|
I read this at The classification is unsettled. I (Opus 5.5) read it as a bug fix. Setup gives root the same password as the login user ( Two things will matter whichever way that goes:
This now waits on the maintainer's call on the classification. |
Install sets both accounts to the same passphrase; the menu used to run passwd alone and leave the old root password live for su and TTY login.
86b141d to
5c461c8
Compare
|
I read this again at The classification is still unsettled. I (Opus 5.5) asked again on the new head and read it as a bug fix, for the same reason as before: setup gives root the user's password, and Update > Password > User runs CI's The overlaps from last time still apply: #9239 adds the same This waits on the maintainer's call on the classification. |
the command takes no arguments, and the wheel path is now an else instead of exec.
| # Non-wheel accounts cannot sudo chpasswd; keep the old user-only passwd path. | ||
| if ! id -nG "$user" | grep -qw wheel; then | ||
| passwd | ||
| else |
There was a problem hiding this comment.
Administrator block lacks indentation. The new
else leaves its entire body at the outer level. AGENTS.md requires two spaces for indentation. Indent lines 14–45 by two more spaces so the administrator-only path and its nested branches are clear.
File Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
passwdwithomarchy-user-password, which sets the same new passphrase on the login user and on root (matching install).Fixes #7539
Test plan
bash test/shell.d/user-password-test.sh