Repository navigation
Conversation
|
Filed the failure this pull request describes: #13319. Reproduced on The patch does not hold up against the r2304 scripts.
Caching sudo belongs on prune, snapshot, keyring, pacman, orphan removal, and service restart. The |
|
The fix for the repeated update prompts is #13321, tracked in #13319. That pull request keeps the cached sudo only through the fixed helpers before migrations, then revokes and installs the no-update wrapper at |
The sleep inhibitor revoked on entry and exit, which cleared the timestamp prune and snapshot had just created. Direct runs still revoke; omarchy-update marks the timestamp as its own so the inhibitor only authenticates with -N. Migrations can run mise or install hooks, so they now start from a cold cache behind the no-update wrapper and revoke again before orphan removal.
|
Pushed Stay-awake no longer clears the update's timestamp. Migrations are the cold boundary. The timestamp is revoked, #13321 keeps the wrapper on for the rest of the run, including orphan removal and service restarts. This branch does not: those two phases are after the second revoke and use a normal
|
|
Thanks for digging into this. Closing in favor of #13323, which makes |
Every sudo call in
omarchy updateprompts for a password, because the no-update wrapper is installed globally at startup (35b318e) on top of per-phase revokes: no timestamp can ever be recorded, so nothing can be reused.Caching sudo covers prune, snapshot, keyring, pacman, orphan removal, and service restarts. Migrations, AUR builds, hooks, and mise authenticate with
--no-update, so a prompt there does not publish a reusable timestamp.bin/omarchy-update: check-only for--no-updatesupport at startup instead of a global wrapper install. The sleep inhibitor is told the update owns the timestamp, so it does notsudo -k. Migrations run between two revokes, with the no-update wrapper first onPATH. AUR, hooks, and mise stay cold behind the wrapper.bin/omarchy-update-stay-awake: a direct run still revokes on entry and exit. From the update it only authenticates the inhibitor withsudo -N.test/shell.d/update-hook-security-test.sh: caching sudo before the migration boundary,sudo -Nonly for the migration itself, caching sudo again for orphan removal, and no-Nbeforeyayoutside that boundary.test/shell.d/update-lock-test.sh: an update-owned inhibitor leaves a pre-seeded timestamp in place. A direct run still starts cold.docs/update-process.md: describe the two cached spans and the cold migration boundary.Verified: update-hook-security, update-user-path, update-sequence, update-lock, and update-stay-awake-security.