Repository navigation
Name what the installed passwordless sudo helper lacks when a root action fails - #13454
Closed
spencerbull wants to merge 1 commit into
Closed
spencerbull wants to merge 1 commit into
spencerbull wants to merge 1 commit into
Conversation
…tion fails Status, enable and disable always run /usr/bin/omarchy-sudo-passwordless as root, whichever copy the user started. When that copy is older than the one started, as under a dev link whose packages predate the checkout, or the boot cleanup rule or revocation hook is missing, the interface reported a generic authorization error, and a failed enable or disable exited without a word. Say which of those is the case instead, keeping the failed action's exit status. Nothing about which copy runs as root changes. Co-Authored-By: Codex XHigh <noreply@openai.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omarchy-sudo-passwordlessruns its status, enable and disable actions as root through the installed/usr/bin/omarchy-sudo-passwordless, whichever copy the user started. That is deliberate: the root half, its expiry timer and the pacman hook must all be root-owned code. When a root action fails because of what is installed, though, the interface does not say so. Two cases hit it:quattro. omarchy-pkgs does not yet install05-omarchy-passwordless-revoke.hook([codex] Revoke passwordless grants when settings is removed omarchy-pkgs#257 does), so publication refuses.__enablefails, and underset -ethe interface exits 1 without a word./usr/bincopy predates the one started, as underomarchy dev linkwith older packages. The old copy answers__statuswith its usage text, and the user sees "Could not safely inspect passwordless sudo… Resolve the reported authorization or cleanup error first", which points at the wrong problem.On those failures the interface now also says what it can see without root: that the installed copy differs from the one started, naming both paths and
omarchy dev pkg-test, and which of the boot cleanup rule and revocation hook is not installed. A failed enable or disable now says so and keeps its exit status. On a consistent install nothing extra is printed, including for a copy at another path whose bytes match. Nothing changes about which copy runs as root.The test fixture maps
INSTALLED_SELFto its generated copy, so these cases do not depend on what the test machine has installed.docs/passwordless-sudo.mdnow says the root actions always use the installed copy, and that the legacy cleanup migration is the one exception.Refs #13421, the report behind this. Its migration half was #13350, and its packaging half is omacom/omarchy-pkgs#257. Not covered here:
__statusstill reads only the UID-named rule, so an old-format rule under the reserved prefix is not reported as active.🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex XHigh.