Repository navigation
Conversation
Automated AI review
Verified: at integer scales the notch math gives the expected floors, and
The floor reaches the reserved area: with The review found an overlap with open PR #13362, a migration that reaches much further than notched top bars, a hidden-bar regression, an override that ignores the panel checks, and an unrelated Windows VM commit. Overlap with open PR #13362#13362 ("Converge omarchy-mac and omarchy-mx-mac into upstream Omarchy") also implements the camera-notch floor (section 9 of its description). Both PRs add Impact: the two PRs conflict as add/add on two files and textually in Suggested change: reconcile with #13362 so only one implementation lands. At minimum, avoid adding a second, different The migration rewrites more layouts than notched top bars, and misses new installs
In an isolated run, In the other direction, Impact: a one-time, user-visible layout change on machines that have no visible notch or no top bar, and no change for new installs or after Suggested change: gate on a visible notch (for example the eDP mode's aspect ratio or Migration conventions: the file is mode 755 where A hidden bar leaves a strip on notched panelsThe hidden-bar margin still parks the bar by
Notification toasts also still clear only Impact: hiding the bar on a notched panel leaves part of it visible, cutting through the widgets at larger floors. These figures come from the source arithmetic and were not observed on a compositor. Suggested change: park and offset by the window's real height (
|
Port the notch height stack so top bars reserve the measured camera cutout on Asahi laptops, accept a calibrated [bar] notch-height override, and migrate Apple Silicon layouts to keep center widgets off the housing. Fixes omacom#13058 Co-authored-by: AnPod <AnPod@users.noreply.github.com>
8249e4f to
4243cff
Compare
|
Heads-up: #13362, which the earlier review flagged as overlapping, was closed today and carried forward in #14431 (the omarchy-mac convergence). #14431 ships its own Separately, the earlier review's migration concerns are still open on this head:
Since #13641 is an identical copy, I'd suggest closing both and folding anything #14431 is missing (for example the measured cutout table) into that PR. |
|
Closing as out of scope: Omarchy now supports only installs made from the official Omarchy ISO, and this change exists for Apple Silicon, which the ISO doesn't produce. We aren't taking on code paths for setups outside that, because nobody here can test or maintain them. The community-maintained omarchy-mac project is the place for Apple Silicon work. Thanks for the work that went into this. (Checked by Claude Opus 5.5; no second review.) |
Summary
On Apple Silicon laptops with a display notch (MacBook Pro 14"/16", MacBook Air), the top bar height was previously fixed at
barSize(26px default), leaving center widgets directly behind the camera housing.This change:
BarModel.js.shell/plugins/bar/Bar.qmlto the notch cutout on Apple Silicon devices.[bar] notch-heightoverride inshell/Commons/Style.qml.test/shell.d/bar-notch-test.shverifying cutout height derivations, override behavior, and layout migrations.Fixes #13058