Repository navigation
Conversation
The bar's Dictate indicator is always shown and clicking it runs omarchy-voxtype-config, which ran voxtype configure unconditionally. Without Voxtype that opened a terminal reading "voxtype: command not found". It now offers the install, as Install > AI > Dictation does, and opens the configuration only when Voxtype is there. Fixes omacom#13594 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Automated AI review
Outcome: Open PR #6832 already makes the same change, and the two PRs conflict in both changed files. Duplicates open PR #6832#6832 (fixes #6823, the same bug as #13594) changes Suggested change: Coordinate with #6832 so that one PR carries the fix (for example keep this PR's stricter test in whichever lands), and link #13594 to #6823. Reproducer (conflict with #6832 at dc9d15e)Checked on 2026-09-28 against #6832 at git init -q repro && cd repro
git fetch -q --filter=blob:none https://github.com/omacom/omarchy.git \
refs/pull/6832/head:refs/pr/6832 refs/pull/13595/head:refs/pr/13595
git rev-parse refs/pr/6832 refs/pr/13595
git merge-tree --write-tree --name-only refs/pr/6832 refs/pr/13595; echo "exit=$?"
git diff refs/pr/6832 refs/pr/13595 -- bin/omarchy-voxtype-configOutput: The two PRs conflict in both files. Apart from the two comment lines, the script is the same in both. Merging either PR into DetailsVerified (source reading, and sandbox runs with stubbed launcher and shell restart):
Also overlapping: #12364 edits the installed branch of the same script and conflicts with this PR in a simulated merge. Optional notes:
Reproducer (optional test note)Optional test-strength note. This is not a behaviour defect: the PR's script passes the stricter stub too. Run from the root of a checkout at tmp=$(mktemp -d)
mkdir -p "$tmp/bin" "$tmp/test/shell.d"
cp test/shell.d/base-test.sh test/shell.d/voxtype-config-test.sh "$tmp/test/shell.d/"
# 1. Break the presence check: ask for the wrong command.
sed 's/omarchy-cmd-missing voxtype/omarchy-cmd-missing voxtypo/' \
bin/omarchy-voxtype-config >"$tmp/bin/omarchy-voxtype-config"
echo "--- PR test against the broken script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"
# 2. Same broken script, with a stub that also checks its argument.
sed -i 's/\[\[ \$VOXTYPE_MISSING == 1 \]\]/[[ $1 == "voxtype" \&\& $VOXTYPE_MISSING == 1 ]]/' \
"$tmp/test/shell.d/voxtype-config-test.sh"
grep -n 'omarchy-cmd-missing"$' "$tmp/test/shell.d/voxtype-config-test.sh"
echo "--- stricter stub against the broken script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"
# 3. Stricter stub against the unmodified PR script.
cp bin/omarchy-voxtype-config "$tmp/bin/omarchy-voxtype-config"
echo "--- stricter stub against the PR script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"
rm -rf "$tmp"Output: Review informationTest scope: Source code and sandbox tests with stubbed launcher and shell restart (the installer itself was not run), at AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
Fixes #13594.
The bar's Dictate indicator is always shown:
omarchy-voxtype-statusreportsidlewhen Voxtype is missing. Clicking it runsomarchy-voxtype-config, which ranvoxtype configureunconditionally. On a machine without Voxtype, that opened a floating terminal readingbash: line 1: voxtype: command not found.omarchy-voxtype-confignow checksomarchy-cmd-missing voxtype(Voxtype is optional, so the presence check fits here). When Voxtype is missing, it launchesomarchy-voxtype-installin the same presentation terminal that Install › AI › Dictation uses. The installer asks before installing anything and restarts the shell itself when it's done. With Voxtype present, behaviour is unchanged.omarchy-voxtype-modelhas the same unconditional call, but nothing in the UI invokes it, so I left it alone.Testing
test/shell.d/voxtype-config-test.shstubs the presence check, terminal launcher and shell restart. Missing Voxtype launchesomarchy-voxtype-install. Installed Voxtype launchesvoxtype configureand then restarts the shell. Onquattrothe first check fails../test/cli: the one failure (vscode generated theme references current theme file) is the same onquattrowithout this change.🤖 Generated with Claude Code