Skip to content

Offer the Voxtype install from Dictate when Voxtype is missing - #13595

Closed
manuaudio wants to merge 1 commit into
omacom:quattrofrom
manuaudio:fix/dictate-offers-voxtype-install
Closed

manuaudio wants to merge 1 commit into
omacom:quattrofrom
manuaudio:fix/dictate-offers-voxtype-install

Conversation

@manuaudio

Copy link
Copy Markdown
Contributor

Fixes #13594.

The bar's Dictate indicator is always shown: omarchy-voxtype-status reports idle when Voxtype is missing. Clicking it runs omarchy-voxtype-config, which ran voxtype configure unconditionally. On a machine without Voxtype, that opened a floating terminal reading bash: line 1: voxtype: command not found.

omarchy-voxtype-config now checks omarchy-cmd-missing voxtype (Voxtype is optional, so the presence check fits here). When Voxtype is missing, it launches omarchy-voxtype-install in the same presentation terminal that Install › AI › Dictation uses. The installer asks before installing anything and restarts the shell itself when it's done. With Voxtype present, behaviour is unchanged.

omarchy-voxtype-model has the same unconditional call, but nothing in the UI invokes it, so I left it alone.

Testing

  • New test/shell.d/voxtype-config-test.sh stubs the presence check, terminal launcher and shell restart. Missing Voxtype launches omarchy-voxtype-install. Installed Voxtype launches voxtype configure and then restarts the shell. On quattro the first check fails.
  • ./test/cli: the one failure (vscode generated theme references current theme file) is the same on quattro without this change.

🤖 Generated with Claude Code

The bar's Dictate indicator is always shown and clicking it runs omarchy-voxtype-config, which ran voxtype configure unconditionally. Without Voxtype that opened a terminal reading "voxtype: command not found". It now offers the install, as Install > AI > Dictation does, and opens the configuration only when Voxtype is there.

Fixes omacom#13594

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@llstrk

llstrk commented Sep 28, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Outcome: Open PR #6832 already makes the same change, and the two PRs conflict in both changed files.

Duplicates open PR #6832

#6832 (fixes #6823, the same bug as #13594) changes bin/omarchy-voxtype-config identically apart from this PR's two comment lines, and adds its own test/shell.d/voxtype-config-test.sh. Merging the two gives a content conflict in the script and an add/add conflict in the test, in either order. Impact: only one can land without manual conflict resolution, and #13594 and #6823 track the same bug separately.

Suggested change: Coordinate with #6832 so that one PR carries the fix (for example keep this PR's stricter test in whichever lands), and link #13594 to #6823.

Reproducer (conflict with #6832 at dc9d15e)

Checked on 2026-09-28 against #6832 at dc9d15ed and this PR at a037073a (git 2.55.0). Run in an empty directory:

git init -q repro && cd repro
git fetch -q --filter=blob:none https://github.com/omacom/omarchy.git \
  refs/pull/6832/head:refs/pr/6832 refs/pull/13595/head:refs/pr/13595
git rev-parse refs/pr/6832 refs/pr/13595
git merge-tree --write-tree --name-only refs/pr/6832 refs/pr/13595; echo "exit=$?"
git diff refs/pr/6832 refs/pr/13595 -- bin/omarchy-voxtype-config

Output:

dc9d15ed3a05a0ee8c6646a9bb3ffbf70a4a167e
a037073a40d1508c9fe0485d4361134d2273a89b
ccebfa3be2a73d8ebafc2c614569df4ff1baeb03
bin/omarchy-voxtype-config
test/shell.d/voxtype-config-test.sh

Auto-merging bin/omarchy-voxtype-config
CONFLICT (content): Merge conflict in bin/omarchy-voxtype-config
Auto-merging test/shell.d/voxtype-config-test.sh
CONFLICT (add/add): Merge conflict in test/shell.d/voxtype-config-test.sh
exit=1
diff --git a/bin/omarchy-voxtype-config b/bin/omarchy-voxtype-config
index d5f703b7..f04a5584 100755
--- a/bin/omarchy-voxtype-config
+++ b/bin/omarchy-voxtype-config
@@ -4,6 +4,8 @@
 
 set -e
 
+# The bar's Dictate indicator is always there, so a click on a machine without
+# Voxtype offers the install, as Install > AI > Dictation does.
 if omarchy-cmd-missing voxtype; then
   omarchy-launch-floating-terminal-with-presentation omarchy-voxtype-install
 else

The two PRs conflict in both files. Apart from the two comment lines, the script is the same in both. Merging either PR into quattro first and the other one second gives the same two conflicts. That was checked in both orders with git merge-tree after a simulated merge commit.

Details

Verified (source reading, and sandbox runs with stubbed launcher and shell restart):

  • Without voxtype on PATH (real omarchy-cmd-missing), head launches only omarchy-voxtype-install; base launched voxtype configure and then restarted the shell.
  • The installed path is unchanged: voxtype configure, then omarchy-restart-shell.
  • The installer call matches Install > AI > Dictation and the first-run invitation; the installer asks with gum confirm and restarts the shell itself only after a confirmed install.
  • The new test passes at head and fails on quattro in the missing case. ./test/cli stops at the same unrelated vscode theme assertion on base and head.

Also overlapping: #12364 edits the installed branch of the same script and conflicts with this PR in a simulated merge.

Optional notes:

  • Optional test improvement: the omarchy-cmd-missing stub ignores its argument, so a script checking the wrong command name (voxtypo) still passes both cases. A stub of [[ $1 == "voxtype" && $VOXTYPE_MISSING == 1 ]] catches that mutant and still passes this PR's script.
  • The omarchy:summary line still reads "Open Voxtype configuration", although the command can now open the installer.
Reproducer (optional test note)

Optional test-strength note. This is not a behaviour defect: the PR's script passes the stricter stub too.

Run from the root of a checkout at a037073a:

tmp=$(mktemp -d)
mkdir -p "$tmp/bin" "$tmp/test/shell.d"
cp test/shell.d/base-test.sh test/shell.d/voxtype-config-test.sh "$tmp/test/shell.d/"

# 1. Break the presence check: ask for the wrong command.
sed 's/omarchy-cmd-missing voxtype/omarchy-cmd-missing voxtypo/' \
  bin/omarchy-voxtype-config >"$tmp/bin/omarchy-voxtype-config"
echo "--- PR test against the broken script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"

# 2. Same broken script, with a stub that also checks its argument.
sed -i 's/\[\[ \$VOXTYPE_MISSING == 1 \]\]/[[ $1 == "voxtype" \&\& $VOXTYPE_MISSING == 1 ]]/' \
  "$tmp/test/shell.d/voxtype-config-test.sh"
grep -n 'omarchy-cmd-missing"$' "$tmp/test/shell.d/voxtype-config-test.sh"
echo "--- stricter stub against the broken script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"

# 3. Stricter stub against the unmodified PR script.
cp bin/omarchy-voxtype-config "$tmp/bin/omarchy-voxtype-config"
echo "--- stricter stub against the PR script"
bash "$tmp/test/shell.d/voxtype-config-test.sh"; echo "exit=$?"
rm -rf "$tmp"

Output:

--- PR test against the broken script
ok - Dictate offers the Voxtype install when Voxtype is missing
ok - Dictate opens the Voxtype configuration when Voxtype is installed
exit=0
10:printf '#!/bin/bash\n[[ $1 == "voxtype" && $VOXTYPE_MISSING == 1 ]]\n' >"$tmp/bin/omarchy-cmd-missing"
--- stricter stub against the broken script
launch voxtype configure
restart
not ok - Dictate offers the Voxtype install when Voxtype is missing
exit=1
--- stricter stub against the PR script
ok - Dictate offers the Voxtype install when Voxtype is missing
ok - Dictate opens the Voxtype configuration when Voxtype is installed
exit=0

Review information

Test scope: Source code and sandbox tests with stubbed launcher and shell restart (the installer itself was not run), at a037073a; not tested on a live desktop.

AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

@manuaudio

Copy link
Copy Markdown
Contributor Author

Thanks, you're right. #6832 already makes this exact change for the same bug (#6823), and it predates this PR by weeks. Closing in its favour. If it helps whoever lands #6832, the stricter stub you suggest (checking $1 == "voxtype") would be worth carrying over.

@manuaudio manuaudio closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dictate bar icon errors with "voxtype: command not found" when Voxtype isn't installed

2 participants