Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryThe PR checks the reserved sudo-rule prefix before reporting inactive access.
Both earlier, unnumbered findings are fixed: the expired-grant path now checks the prefix, and the test removes its shared fixtures. No new actionable issues were found. This review used code inspection; no tests were run. Reviews (3) · Last reviewed commit: "Refuse inactive status while a reserved-..." · Reviewed by Greptile |
|
Reviewed and verified, with fixes pushed to your branch. Thanks @Bartok9, the bug is real: on current What was pushed:
Checked on a disposable Omarchy worker at bc28eb3:
Second opinion: Codex Medium reviewed two rounds. The first found the two gaps in the numeric skip and the expiry test that are fixed above. The second found nothing open and agreed the change is proportionate; that agreement is not guaranteed to be independent. Out of scope and left for the maintainer: when a live UID grant and a legacy rule coexist, status is This is now waiting on the maintainer. |
|
Thanks — the expiry-path check and the contents-based skip for another account’s rule match the bug. Leaving the coexist case (live UID grant plus a legacy rule) for the maintainer is fine; this PR should stay scoped to refusing a false inactive status. Ready for maintainer review at bc28eb3. |
A missing UID-named grant is not confirmed inactive when the legacy writer left another rule under 99-omarchy-nopasswd-*. Check the reserved prefix on every inactive status, not only a missing rule An expired UID rule was removed and reported inactive without looking at the rest of the prefix, so a live legacy rule still read as no grant. Another account's UID-named rule is that account's grant, so it no longer turns this account's status into an error on a shared machine. The test removes its fixtures so later cases start from an empty sudoers.d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Skip another account's rule only when its contents name that account A numeric filename does not say whom the rule grants: a noncanonical 01000, or a UID reassigned while a grant was live, can still name this account. The expiry case now proves the grant was active before expiring it, so it cannot pass on the missing-rule path alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
bc28eb3 to
54a88cf
Compare
|
Re-checked after the squash and rebase, @Bartok9. The fix's diff to Checked on disposable Omarchy workers at 54a88cf:
Second opinion: Codex Medium and muse-wonder (via pi, thinking high) each traced every path into Still for the maintainer, as before: whether a leftover legacy rule should block status until reboot or be migrated or removed, and the coexisting live-grant case noted earlier. This is waiting on the maintainer. |
Summary
__statustreated a missing UID-named grant as confirmed inactive (3) even when another file remained under the reserved99-omarchy-nopasswd-*prefix.3, which over-claimed "no grant".2) when any other reserved-prefix file is present, and leaves that file in place. Closes the open remainder ofomarchy sudo passwordlessis broken on a dev-linked checkout: the privileged half is hardcoded to a stale/usr/bincopy #13421.Test
bash test/shell.d/nopasswd-sudo-expiry-test.sh— new case: a99-omarchy-nopasswd-jacobrule makesstatus_locked 1000return2and does not remove the file. That case passed in an Ubuntu container. The later public-status assertion (status must not publish reusable authorization) also fails on unmodifiedquattroin that container, so it is not this change.