Repository navigation
Added all indicators names in the manual - #14070
CowGivesMilk wants to merge 5 commits into
Conversation
[Low impact] The PR appears safe to merge. SummaryThe PR adds a copyable JSON array of default indicator names to the top-bar manual. The array matches the current widget defaults. Reviews (3) · Last reviewed commit: "List the indicator defaults quattro ship..." · Reviewed by Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
chessing234
left a comment
There was a problem hiding this comment.
everything seems fine, ready to merge.
The indicator defaults changed on quattro after this branch was made, so the list the manual names has to be checked against the code it will land beside.
Dictation's indicator was removed in omacom#14552, and PasswordlessSudo and RemoteSession were added since, so the list now matches defaultIndicatorEntries in shell/plugins/bar/widgets/Indicators.qml. Each name is the file under shell/plugins/bar/indicators/ that the widget loads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for this. Listing the names is useful: the hover text shows what each indicator does, not the id The list needed updating for current What was checked: this is a Markdown-only change, so nothing was run. I read it against the code at the new head, as described above, and confirmed in Codex also pointed out a few things in the surrounding paragraph that were already out of date before this PR and are left alone here: line 76 still lists dictation and doesn't mention passwordless sudo, clicking the reminder indicator opens reminders rather than toggling a mode, and Nothing is needed from you. This is waiting on the maintainer. |
A copy of defaultIndicatorEntries in the manual has to be edited every time an indicator is added or removed, and it had already gone stale once. The maintainer asked for it to go rather than be kept in sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@CowGivesMilk, the maintainer asked for the default indicator list to come out of the manual rather than be kept in step with That sentence was the whole of this pull request's change, so it now changes no files against Checked by reading only, since nothing runs: the edit restores
Waiting on the maintainer. |
In the manual, Top bar indicators sections didn't have the exact name of all items which made it harder to edit .config/omarchy/shell.json since the text on hover does not show the item name on hover but only what it does like 'StayAwake' is not mentioned anywhere.