Skip to content

Added all indicators names in the manual - #14070

Open
CowGivesMilk wants to merge 5 commits into
omacom:quattrofrom
CowGivesMilk:include-all-indicators-names
Open

CowGivesMilk wants to merge 5 commits into
omacom:quattrofrom
CowGivesMilk:include-all-indicators-names

Conversation

@CowGivesMilk

Copy link
Copy Markdown

In the manual, Top bar indicators sections didn't have the exact name of all items which made it harder to edit .config/omarchy/shell.json since the text on hover does not show the item name on hover but only what it does like 'StayAwake' is not mentioned anywhere.

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The PR adds a copyable JSON array of default indicator names to the top-bar manual. The array matches the current widget defaults.

Reviews (3) · Last reviewed commit: "List the indicator defaults quattro ship..." · Reviewed by Greptile

Comment thread manual/05-the-top-bar.md Resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

@chessing234 chessing234 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems fine, ready to merge.

@omarchybot omarchybot added the documentation Improvements or additions to documentation label Oct 15, 2026
omarchybot and others added 2 commits October 15, 2026 07:06
The indicator defaults changed on quattro after this branch was made, so the list the manual names has to be checked against the code it will land beside.
Dictation's indicator was removed in omacom#14552, and PasswordlessSudo and RemoteSession were added since, so the list now matches defaultIndicatorEntries in shell/plugins/bar/widgets/Indicators.qml. Each name is the file under shell/plugins/bar/indicators/ that the widget loads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 15, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for this. Listing the names is useful: the hover text shows what each indicator does, not the id items expects.

The list needed updating for current quattro. The Dictation indicator was removed in #14552, and PasswordlessSudo and RemoteSession have been added since this branch was made, so Dictation would have loaded nothing. I merged quattro into the branch and changed the list to ["PasswordlessSudo", "ScreenRecording", "RemoteSession", "Reminder", "NightLight", "Dnd", "StayAwake"] (63337b3). That matches defaultIndicatorEntries in shell/plugins/bar/widgets/Indicators.qml:11, name for name and in order. Each name is also an option in the widget's manifest and the name of a file the widget loads from shell/plugins/bar/indicators/.

What was checked: this is a Markdown-only change, so nothing was run. I read it against the code at the new head, as described above, and confirmed in docs/i18n.md that a pull request only needs the English chapter. Codex Medium reviewed the same and found no defects in the added sentence. It largely agreed with my reading, and its independence is not guaranteed.

Codex also pointed out a few things in the surrounding paragraph that were already out of date before this PR and are left alone here: line 76 still lists dictation and doesn't mention passwordless sudo, clicking the reminder indicator opens reminders rather than toggling a mode, and alwaysShow doesn't reveal an inactive remote-session indicator.

Nothing is needed from you. This is waiting on the maintainer.

@omarchybot omarchybot removed the ready Good to merge label Oct 31, 2026
A copy of defaultIndicatorEntries in the manual has to be edited every time an indicator is added or removed, and it had already gone stale once. The maintainer asked for it to go rather than be kept in sync.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot removed the verified Omarchy Triage has verified that this issue is ready for final review label Oct 31, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

@CowGivesMilk, the maintainer asked for the default indicator list to come out of the manual rather than be kept in step with defaultIndicatorEntries in shell/plugins/bar/widgets/Indicators.qml: a copy of that array has to be edited whenever an indicator is added or removed, and it had already gone stale once on this branch. I removed the sentence in 3eddc95.

That sentence was the whole of this pull request's change, so it now changes no files against quattro and there is nothing left to merge. Whether to close it is the maintainer's call. Thanks for raising it: the point that items wants ids the hover text never shows is a fair one.

Checked by reading only, since nothing runs: the edit restores manual/05-the-top-bar.md line 78 to its quattro wording on one unwrapped line. Codex Medium and muse-wonder (pi, thinking high) reviewed the change and the reading of the request; both agreed, and their independence is not guaranteed. Both also found two older inaccuracies in the same section on quattro that this pull request never touched, which I confirmed in the source:

  • Line 76 still lists dictation among the indicators. The Dictation indicator was removed in Add selectable Voxtype and Superwhisper dictation #14552, and the paragraph doesn't mention the passwordless sudo indicator at all.
  • "Clicking an indicator toggles that mode" doesn't hold for reminders: shell/plugins/bar/indicators/Reminder.qml shows the queued reminders, or opens the new-reminder flow when there are none.

Waiting on the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants