Repository navigation
Fix Antigravity collector overflow on zero timestamps - #14098
steph4n-gh wants to merge 1 commit into
Conversation
|
|
Reviewed, and the fix holds. Nothing was pushed. Reproduced on a disposable Omarchy worker. I ran the collector with Tests on the worker: Second opinion, from Codex at medium effort: no blocking defect. It agrees with the reasoning above, though it may have seen that reasoning, so its agreement isn't independent. Its caller audit is its own: valid timestamps parse to the same dates as before, and a zero-time login expiry, quota reset or cached window is now treated as unknown rather than expired. A zero-time history row now counts as no prompt in every zone, where in UTC it used to count as a prompt dated Scope: the collector change is the size of the bug. The test file is larger: lines 153–257 exercise login expiry, quota reset display and cached-window pruning. Those are the other callers of the shared This is labelled |
Antigravity conversation summaries can contain Go's year-0001 zero timestamp. Converting it to local time west of UTC crosses into year zero and crashes the collector with
OverflowError. Reproduced with synthetic data from the original report.Treat the exact zero sentinel as undated and guard timestamp parsing and local conversion narrowly. Valid activity, session accounting, and lifetime token totals remain intact; bad dates cannot suppress valid records or enter today's counts.
Validation: all nine timestamp tests pass on Python 3.14.8 and system Python 3.14.7, covering UTC, UTC−5, UTC+9, mixed records, boundaries, and shared login expiry/reset/cache callers. All 17 isolated collector suites and affected scanner, limits, updater, and panel tests pass, as do shell syntax, whitespace, and patch application checks. No live service calls were made. Independent review has no remaining findings.
./test/clihas the preexistingvscode generated theme references current theme filefailure, reproduced on the unmodified base. Full shell/aggregate suites, graphical acceptance, live-service tests, and CLI checks after that failure were not completed.Companion to #14039, targeting its
agents-hermes-antigravity-providersbranch. The separate adaptation for the author'sf008cf62antigravity collector is not included.