Repository navigation
Prevent lid closure from interrupting reboot - #14248
chemineer1 wants to merge 5 commits into
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryExtends the existing lid and sleep inhibitor to reboot and firmware reboot. Logout remains uninhibited.
Reviews (6) · Last reviewed commit: "Merge quattro: keep the firmware reboot ..." · Reviewed by Greptile |
chessing234
left a comment
There was a problem hiding this comment.
Reviewed head d3e8d51bb093eaed80ff152b0f611d7b95eea006.
Reviewed detached scheduling, inhibitor scope, checkout preservation through $0, and independent OSD/preparation dispatch. The focused harness exercised the command wiring, but some test stubs refer to Linux-only /usr/bin/sleep, so this is not native timing/inhibition validation. No additional verified production defect found.
|
@greptileai Please re-review the current revision and refresh the summary. The OMARCHY_PATH finding was withdrawn, and the OSD preparation issue was fixed in d3e8d51. |
|
Read the diff at What reading it found:
Next: waiting on a second opinion to settle the classification. After that, the port onto |
|
Reviewed again at What was checked, on a disposable Omarchy worker with real systemd:
Second opinion: Codex Medium reviewed the diff statically and found no defects. It agreed that the problem is real and that two production lines plus tests are proportionate. Its independence from this review is not guaranteed. It noted that the test mocks log arguments with No other open pull request adds lid inhibition to reboot. #11151 also edits Waiting on the maintainer. |
|
@greptileai A clarification on the OSD caveat in the latest summary for The original finding concerned the reboot request overtaking OSD, state clearing, and window-close preparation in a background worker. The current consolidated exit sequence runs OSD, state clearing, and the bounded application-close wait sequentially before requesting reboot. That earlier race therefore does not carry over to this implementation. A slow OSD can still delay the sequence; this is existing behavior from #15231, and this PR preserves it while extending the shutdown inhibitor to both reboot actions. Please distinguish that inherited behavior from the resolved preparation race in the summary. The physical lid-close test also passed on the current revision on October 15, using a Dell XPS 13 DX13260. The recorded script hash matches
The PR description now includes these results. This was one physical standard reboot on one laptop, with timestamp/inhibitor instrumentation; reboot-to-boot-menu remains covered by automated and real-systemd tests using harmless power stubs, rather than a physical test. |
|
That clarification is correct. The earlier OSD/state-clearing/window-close race does not apply to The physical test supports the standard reboot path: it confirms the lid remained closed while the inhibitor was held and logind accepted the request without an intervening suspend. The reboot-to-boot-menu path remains covered by automated and real-systemd stub tests rather than a physical test. |
quattro removed the reboot-boot-menu action (omacom#15795), so the lid inhibitor now covers reboot and shutdown, and the tests check reboot alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This stopped merging after #15795 removed the What was checked at
Second opinion: Codex Medium reviewed the merge without running anything and found no defects. It agreed that the resolution loses nothing from either side, that none of the edited loops now passes without testing anything, and that the change is still correct and proportionate on current No open issue or competing pull request covers lid inhibition during reboot. This is labelled |
quattro added the firmware action (omacom#19003) and the delayed exit OSD (omacom#19006). The lid inhibitor applies to every action but logout, so reboot to the BIOS is held against lid suspend too, and the firmware test's systemctl mock now requires the inhibitor for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This stopped merging after #19003 added a Because the inhibitor applies to every action except What was checked at
Second opinion: Codex Medium and muse-wonder (via pi, thinking high) reviewed the merge without running anything and found no defects. They agreed that the resolution loses nothing from either side, that the firmware test still tests something, and that holding the inhibitor through the delayed OSD's wait after the request cannot block the reboot itself, because it does not inhibit shutdown. Their independence from this review is not guaranteed. No open issue or competing pull request covers lid inhibition during reboot. This is labelled |
Closing the lid while Omarchy prepares to reboot can suspend the laptop. This extends the shutdown protection introduced in #13076 to standard reboot and reboot to firmware setup, using the same
sleep:idle:handle-lid-switchinhibitor from before applications close through the power request. The inhibitor reason uses the localized progress message. Logout remains uninhibited.Validation at
b0a11abd, reported by omarchybot:A standard reboot with the lid closed completed without suspending on a Dell XPS 13 (DX13260) at the earlier revision
94f27639. Reboot to firmware setup has not been tested on hardware.