Repository navigation
Conversation
|
|
Thanks for tackling #12625! Two things:
Small nit: |
|
An alternative solution to this is to package zed in the omarchy-pkgs repo for aarch64, so that there's no need to work around it. Edit: Looks like the omarchy-mac guys also ran into this and added it https://github.com/omacom/omarchy-pkgs/blob/master/pkgbuilds/zed/PKGBUILD |
On aarch64 the omarchy repo publishes omazed but no zed package, so the single 'omarchy-pkg-add zed omazed' transaction aborted and neither got installed. Keep the existing transaction when zed is available; otherwise install omazed on its own and use Zed's official installer. Fixes omacom#12625
Omarchy's default-editor flow launches zeditor, but zed.dev/install.sh only installs ~/.local/bin/zed. Link zeditor to it when no zeditor is on PATH, and make the test's mock installer create the zed CLI so the command Omarchy runs is checked.
A failing pacman -Si (stale sync DB, unreachable mirror) no longer sends x86_64 to the remote installer; only non-x86_64 without a zed package falls back. ln -sfn replaces a broken zeditor entry left by an earlier attempt.
|
|
||
| echo "Installing Zed Editor..." | ||
| omarchy-pkg-add zed omazed | ||
| if [[ $(uname -m) == "x86_64" ]] || pacman -Si zed &>/dev/null; then |
There was a problem hiding this comment.
Missing Zed blocks installation
If the configured repository has omazed but no zed package on x86_64, this condition skips the availability check and tries to install both packages in one transaction. That transaction fails, so neither package is installed and the upstream fallback never runs.
| if [[ $(uname -m) == "x86_64" ]] || pacman -Si zed &>/dev/null; then | |
| if pacman -Si zed &>/dev/null; then |
|
Thanks, re-checked: x86_64 now always uses the package, and the dangling On Greptile's P1: failing loudly on x86_64 when |
|
Thanks, x86_64 now always goes through the package, and Following up on @TravonteD's note: omacom/omarchy-pkgs has shipped an aarch64 |
|
Thanks for picking up #12625. The bug it describes was real when the issue was filed, but it has since been fixed in packaging, so this change should no longer be needed. What closes it: omacom/omarchy-pkgs#612 (merged 2026-09-24) added an aarch64 With the package published, the new branch here runs only when the local sync database predates it, and then it does something worse than failing: it installs a self-updating Zed under What was checked: the diff read against This now waits on the maintainer, with a recommendation to close it alongside #12625 once an ARM install confirms the packaged Zed installs. |
|
Closing, already fixed upstream via omacom/omarchy-pkgs#612. |
Summary
Fixes #12625.
omarchy install editor zedrunsomarchy-pkg-add zed omazedas one pacman transaction. On aarch64 the omarchy repo publishesomazed(arch=any) but nozedpackage, so pacman aborts the whole transaction and neither Zed nor omazed gets installed.What changed
bin/omarchy-install-editor-zed: ifpacman -Si zedresolves, keep the existingomarchy-pkg-add zed omazedtransaction (x86_64 behaviour unchanged). Otherwise installomazedon its own and fall back to Zed's official installer (https://zed.dev/install.sh), which ships aarch64 Linux builds.omazed setupand the launch step are unchanged.test/shell.d/zed-install-test.sh: new test covering both paths (repo package available vs. unavailable) with stubbedpacman,omarchy-pkg-addandcurl.test/shell.d/desktop-entry-launch-test.sh: stubpacmanso the existing installer launch test keeps exercising the package path.Testing
bash test/shell.d/zed-install-test.sh: 2 okbash test/shell.d/desktop-entry-launch-test.sh: all okbash -nandshellcheckon the changed script: clean