Repository navigation
Conversation
gum input stops at 400 characters, so a 3072-bit RSA key or an OpenSSH certificate is truncated and reported as invalid.
[Medium impact] The PR appears safe to merge. SummaryRemoves the character limit from the SSH public-key prompt so users can paste long keys.
Reviews (3) · Last reviewed commit: "Merge quattro into fix/sshd-paste-key-li..." · Reviewed by Greptile |
chessing234
left a comment
There was a problem hiding this comment.
everything seems fine, ready to merge.
quattro moved the public-key prompt to omarchy-i18n; keep that prompt and add --char-limit=0 to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since quattro localized the sshd prompts, the paste path calls omarchy-i18n to build its menu and prompt. Without $ROOT/bin on PATH and OMARCHY_PATH pinned, the test used whatever Omarchy the machine had installed, and failed where none was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Reviewed and verified. The fix is right: This branch conflicted with
On a fresh Omarchy worker VM at 3bd4d7e: Second opinion: Codex Medium, over two rounds. The first found the test's dependency on an installed It closes #14351 and now waits on the maintainer. |
quattro's omacom#14667 rewrote the sshd setup test with its own gum stub for a cancelled prompt, which conflicted with this branch's stub. The test file is taken from quattro as is, dropping this branch's pasted-key case: its gum stub supplied the 400-character limit the case tested, and it grepped for the flag the fix adds, both against AGENTS.md's test rules. The fix itself, --char-limit=0 on the public-key prompt, merges cleanly onto quattro's reordered script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@z23 this branch conflicted with The conflict was only in Checked on a fresh Omarchy worker VM, using the real
Second opinion: Codex Medium and muse-wonder (via pi, thinking high) both reviewed 68a83a3 and found nothing open. Both agreed the merge keeps all of #14667, that dropping the stub test follows It still closes #14351 and now waits on the maintainer. |
Fixes #14351
gum inputdefaults to--char-limit=400.omarchy setup security sshduses that prompt for "Paste key manually", then checks the result withssh-keygen -lf. A 3072-bit RSA public key is about 570 characters, so the prompt keeps a prefix,ssh-keygenrejects it, and the command prints "Not a valid SSH public key". An OpenSSH certificate is longer still. Ed25519 keys fit, which is why the placeholder example works.The public-key prompt now passes
--char-limit=0(no limit). The GitHub username prompt is unchanged.The sshd setup test stubs
gumwith that 400-character ceiling, pastes a generated 3072-bit key, and checks thatauthorized_keysreceives the whole line and password logins are still turned off. The same case fails on the old prompt.