Repository navigation
Add Microsoft Surface Pro 11 board support - #14390
Conversation
bf8493a to
5586e89
Compare
dcdea0b to
2f83505
Compare
5586e89 to
747e56f
Compare
|
I rebased this onto today's |
|
Two notes for when the packages land, both about how The stock kernel is removed with The model check reads the device tree directly, where Getting the Surface packages into the Snapdragon image is on the ISO side. We will pick that up in omarchy-iso once the packages are published. |
747e56f to
cde3105
Compare
|
I rebased this onto today's |
|
Thanks for the rebases, Birk. I reset my branch to cde3105 and added two commits on top.
|
|
The helper is up as #15064. With it the check becomes One more thing since #14952 went in. The generic device tree list now takes Omarchy's kernel's own trees first, so the comment above the Denali block is out of date. |
|
Thanks, Birk. The comment now says why the tree is still pinned: the list holds this kernel's trees, but systemd-stub picks among them by SMBIOS identity, which the OLED, LCD and X Plus models share (2273427). The switch to |
|
#15064 is merged, so |
2273427 to
c54f583
Compare
|
Rebased onto |
|
One line still has the old name, and that is my doing. I renamed the helper after my first note here, and the mail you got still said |
|
I pushed the one-word fix on top as 4341a3f, since the mix-up came from my side. It is a normal push with nothing rewritten, so a |
|
Thanks for pushing that, Birk. I've pulled it, so the branch is at 4341a3f here too. I checked the detection on the Surface Pro 11 itself, booted on linux-omarchy-n1x 7.2.8-6. I haven't run a full install yet. The script installs linux-omarchy-n1x and the Surface packages from omarchy-pkgs #825–#829, #972 and #975, and none of them are on edge aarch64 yet, so for now it would stop at the first |
[Medium impact] The reviewed changes appear safe to merge. SummaryAdds board-specific setup for the Surface Pro 11 OLED.
The earlier failed-kernel-install concern no longer applies: this version does not replace the kernel and only pins a device-tree file that already exists.
|
|
One small thing. The early-boot list names Beyond that the script looks good to me. I'd merge it once the packages are published and your full install is in. |
|
Thanks, fixed in 762a554: it's |
5020555 to
d621e82
Compare
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
|
Omabot looked at this pull request at 307f94b to classify it, and the classification is not settled yet, so it has no class label and nothing was run on a worker. Two models classified it separately. Claude Opus 5.5 read it as an Next it waits on the maintainer to say which it is. Nothing here is waiting on you, and the full install you are planning for once the omarchy-pkgs packages are published is still the test that counts. |
307f94b to
17e7430
Compare
|
Rebased onto This still waits on the Surface packages, omacom/omarchy-pkgs#825 ( |
17e7430 to
ab856dd
Compare
|
Omabot classified this again at ab856dd, after the rebase onto For the maintainer: #15031 takes a different route to the same machine, an This waits on the maintainer to say which class it is. Nothing here is waiting on you beyond the full install you already planned once the omarchy-pkgs packages are published. |
The Surface Pro 11 (Snapdragon X Elite, OLED, microsoft,denali-oled) needs a kernel with its touch and pen digitizer, keyboard cover and cameras, and its own device tree. The UKI's device tree setting applies to every kernel, so linux-sp11 replaces linux-aarch64 rather than sitting beside it. Write the boot configuration first, so the Surface kernel's image is built with it when the kernel installs: the Surface device tree in uki.conf, early display, USB-C and keyboard modules plus firmware for the unlock screen (Surface modules optional, so a stock kernel's image still builds), and a boot order that prefers linux-sp11. Remove the Intel Surface keyboard module file an earlier install may have written. Then install linux-sp11 (and its headers if the stock headers were present) with surface-pro-11-support, and only after that remove the stock kernel, so a failed install leaves it in place. Install libcamera with IMX681 support, replacing a stock libcamera if one is present, then iptsd, the light sensor package and the power-profiles-daemon build that reaches the Surface's platform profile, and enable the sensor and CPU limit services. The LCD and X Plus models are left alone until tested. Validated with test/shell.d/surface-pro-11-hardware-test.sh and the surface, yoga-slim7x and snapdragon hardware tests. An earlier revision of this script set up the Surface Pro 11 in daily use from a dragon ISO install; this revision reorders it and has only been validated by the tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
n1x.sh drops linux-aarch64 the same way, and AGENTS.md asks for the helper over raw pacman -R. -Rdd was not needed: linux-aarch64 depends only on coreutils, kmod and mkinitcpio, which linux-sp11 needs too, so -Rns takes nothing else with it. Validated with test/shell.d/surface-pro-11-hardware-test.sh and the surface, snapdragon and yoga-slim7x hardware tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
linux-omarchy-n1x now carries the Surface Pro 11 patches (omarchy-pkgs omacom#975), so the board script installs it instead of linux-sp11, still in place of the stock kernel, and points the UKI at that package's Denali device tree. Omarchy's defaults already boot linux-omarchy-* first, so the script no longer writes its own boot order and removes the linux-sp11 one an earlier revision left. Validated with test/shell.d/surface-pro-11-hardware-test.sh and the surface and snapdragon hardware tests. A Surface Pro 11 booted linux-omarchy-n1x with the Surface Pro 11 patches and this device tree in its UKI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ds the kernel's own Since omacom#14952 the generic list takes Omarchy's kernel's trees first, so the old reason, that its trees belonged to the stock kernel, no longer holds. The tree is still pinned because systemd-stub chooses among the list by SMBIOS identity, which the OLED, LCD and X Plus models share. Validated with test/shell.d/surface-pro-11-hardware-test.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The OLED, LCD and X Plus models share a DMI name, so the script read the device tree itself. omarchy-hw-match-device-tree (omacom#15064) does that for any such model, and the test fakes the tree through OMARCHY_PROC_ROOT like the other platform tests, skipping as root where fixtures are ignored. Validated with test/shell.d/surface-pro-11-hardware-test.sh, hw-match-device-tree-test.sh, snapdragon-hardware-test.sh and surface-hardware-test.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omarchy-hw-dt-match became omarchy-hw-match-device-tree before omacom#15064 went in, so the old name is not on n1x and the model check was always false.
… install The Surface device tree is written before linux-omarchy-n1x installs, so the kernel's image is built with it. If that install failed, the stock kernel was kept but its next image rebuild pointed at a device tree that was never installed. The previous configuration is now put back first. Validated with the Surface Pro 11, Snapdragon and Surface tests on the Surface Pro 11 (X1E OLED). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The stock kernel has no videocc_sm8550, so mkinitcpio exited 1 with "module not found" when it built that kernel's image, while linux-omarchy-n1x has it and still loads it early. Validated with the Surface Pro 11 and Snapdragon tests on the Surface Pro 11 (X1E OLED), where linux-omarchy-n1x 7.2.8-6 has every module in the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
linux-omarchy-n1x's IMX681 driver now exposes a linear gain and surface-pro-11-support ships the front camera's tuning, so Arch's libcamera drives both cameras. Install pipewire-libcamera with omarchy-pkg-add instead of replacing libcamera with libcamera-surface-pro-11. Validated on a Surface Pro 11 with Arch's libcamera 0.7.2-4: front and back cameras in Snapshot, gain following the light, before and after suspend. The Surface Pro 11, Surface, Snapdragon and Yoga hardware tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Surface-specific power-profiles-daemon build and the CPU cap service are gone: omarchy-power-profiles-daemon caps the CPU clusters on every Snapdragon X laptop (omacom/omarchy-pkgs#1029). Validated with test/shell.d/surface-pro-11-hardware-test.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The kernel has been linux-omarchy since 13 October, with its device trees under /boot/dtbs/linux-omarchy, so the Surface Pro 11 setup installs and pins it by that name.
Only its hardware setup installs surface-pro-11-support, iptsd and surface-pro-11-sensors, so without a listing the ISO's offline mirror lacks them and the install stops on "target not found". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leave the kernel to the installer, which puts linux-omarchy on every aarch64 machine, and the camera backend to qualcomm/camera.sh. The OLED model's device tree replaces the generic list only when linux-omarchy provides it, and the change is written and flagged for an image's rebuild the way dtb-uki.sh does. Cleanups for files that only earlier test revisions of this script wrote go too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without Omarchy's kernel the script now removes its own device-tree pin instead of leaving one to a file that is gone, which would stop the UKI from building. The tree is found under any linux-omarchy package directory, as dtb-uki.sh finds it, and every early module is optional, as in qualcomm/initramfs.sh, so a kernel without one still builds its image. A keyboard module file from before the Intel Surface fixes were limited to x86 is removed again: it sorts after this drop-in and resets MODULES. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ab856dd to
feb215d
Compare
|
@turbineBMW The script, its test and the module names on 7.3 check out here. Two things before this goes in. The three packages are aarch64-only, and omarchy-iso's x86_64 build only leaves out what's in |
|
Thanks! The omarchy-iso change is up as omacom/omarchy-iso#308, so the x86_64 ISO leaves the three packages out. The full install run is on the published packages: I built an aarch64 ISO from this branch against edge, which has |
|
Omabot classified this again at feb215d, and the two models split the same way as before: Claude Opus 5.5 reads it as an What has changed since the last note is on your side: the x86_64 ISO change is up as omacom/omarchy-iso#308 and the full install on the published packages is in the description. Nothing here is waiting on you now. For the maintainer: whether this is a feature to take or a hardware fix to verify is the open question, and #15031, an |
Summary
Board setup for the Surface Pro 11 (Snapdragon X Elite, OLED,
microsoft,denali-oled), in the pattern ofyoga-slim7x.sh. The installer putslinux-omarchyon every aarch64 machine, and that kernel carries the Surface Pro 11 patches, so this script leaves the kernel alone.qualcomm/initramfs.sh) so any kernel's image builds.linux-omarchyin place of dtb-uki.sh's list, which can't tell the OLED, LCD and X Plus apart (they share an SMBIOS identity). The tree is found underlinux-omarchy*and the config is written only when it changes, flagging an image's rebuild, as dtb-uki.sh does. Without that tree the list stays and an earlier pin is removed, so the UKI still builds.surface-pro-11-support(Wi-Fi board data, audio, camera routing),iptsd(pen and touch) andsurface-pro-11-sensors(ambient light), and enables the sensor service. All three are listed inomarchy-other.packages, so the offline ISO carries them.surface_device_modules.confleft by installs from before Keep Intel Surface fixes off Snapdragon Surfaces #14389. It sorts after this drop-in and resetsMODULES.Dependencies
All landed:
linux-omarchywith the Surface Pro 11 patches), Add surface-pro-11-support: Wi-Fi, audio, Bluetooth, charge window, keyboard pairing and pen resume omarchy-pkgs#825 (surface-pro-11-support), Add iptsd for Surface pens on aarch64 omarchy-pkgs#826 (iptsd), Add Surface Pro 11 ambient light sensor support omarchy-pkgs#828 (surface-pro-11-sensors), Add surface-snapdragon-addresses for Snapdragon Surface Wi-Fi and Bluetooth addresses omarchy-pkgs#972 (surface-snapdragon-addresses)Test plan
test/shell.d/surface-pro-11-hardware-test.sh: rerun idempotence, the device-tree pin with and withoutlinux-omarchy, the image rebuild flag, early firmware, offline package listing, other Denali variants untouchedsurface,snapdragon,yoga-slim7x,thinkpad-t14s-camera,camera,mkinitcpio-hooks, platform and device-tree tests pass on currentquattrouki.confand packages; the only change is the optional?on the early modules, all present inlinux-omarchy7.2.8-23