Repository navigation
Conversation
|
71c33e7 to
97c43c2
Compare
97c43c2 to
ad2530b
Compare
|
Pinning the logger to NIT only: the log path is still |
|
Reviewed at ad2530b, and nothing needs changing. I reproduced the bug on a worker built from the Omarchy ISO, with the real The re-exec still passes On the worker, Codex at medium effort reviewed the diff as a second opinion, with the same questions: proportionality, the security startup checks, the quoting, and whether the test could pass vacuously. It found no defects. It agreed with my review, and its independence is not guaranteed. This doesn't close #11630. That report has the update exit 0 without creating a log. Here the update exits with the shell's status, and the log is created. This is now waiting on a maintainer. |
|
This branch no longer merges into #17000, merged on 31 October, turned
The reproduction from 16 October still holds for this head against the Codex at medium effort and muse-wonder (via pi, high thinking) reviewed the conflict, #17000 and the shell question as second opinions. Both agreed that #17000 removed the protections this PR relies on, that ordinary updates from fish, zsh and nushell don't fail on This is waiting on a maintainer to decide whether it is still wanted after #17000. If it is, the version that fits |
omarchy-updatepasses a Bash-escaped command toscript(1), butscriptselects its command interpreter from the inheritedSHELL. An uncommon shell or wrapper can therefore intercept or misinterpret the logging re-exec.Pin the logging boundary to
/usr/bin/scriptand/usr/bin/bash, then restore the caller's exportedSHELLonly inside the trusted Bash command. The update keeps the caller's existingPATHthrough the logging and lock re-execs, and preserves an unsetSHELLas unset.The Omarchy security team classified the original report as same-user hardening and invited a regular pull request.
Validation
bash test/shell.d/update-user-path-test.shbash test/shell.d/update-hook-security-test.shbash test/shell.d/update-sequence-test.shbash test/shell.d/security-entrypoint-symlink-test.shbash -non the changed shell filesgit diff --checkThe regression covers exported and unset
SHELL, the logging and lock re-execs, caller-installed tools onPATH, and a checkout path containing=. It fails on unpatchedquattroand passes with this change../test/allexercised all 322 shell-test files. The changed-path tests passed; 19 unrelated environment or companion-checkout failures remained. Both updater-area failures reproduce unchanged on currentquattro.Related: #11630 reports a silent exit at the same
script -qefcboundary. Its environment does not identify the inherited shell, so this change does not claim to close it.🤖 Generated by Codex (GPT-6) on behalf of Steven Brown (@wickthumb).