Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryAdds T1 Touch ID detection and preserves T1Bridge’s installed fingerprint drivers.
|
|
A caveat I found after opening this, so nobody is surprised by it. The last step of setup, I left the code as it is. The lock screen is the right place to fix this, and #12461 would bound it for every reader, so special-casing Touch ID in setup would only paper over it. Until #12461 or a T1Bridge fix lands, the workaround on a T1 is to remove |
|
Thanks for the thorough write-up and the hardware run on the MacBookPro14,3. This pull request has not been reviewed further yet, because the two models that classify each item disagreed on what it is. Claude Opus 5.5 read it as an enhancement: on No other open pull request or issue about T1 Touch ID or fingerprint setup turned up. This is waiting on the maintainer to settle what it is. |
# Conflicts: # bin/omarchy-setup-security-fingerprint # test/shell.d/hw-fingerprint-test.sh
Summary
On 2016-2017 Touch Bar MacBook Pros (MacBookPro13,2/13,3/14,2/14,3), Touch ID works on Linux through T1Bridge, which ships its own matched
libfprint-t1bridge/fprintd-t1bridgepair. Omarchy's fingerprint setup doesn't know about it, in two ways:omarchy-hw-fingerprintreturns false, so the Fingerprint menu entry and the first-run invitation never show up, andomarchy-setup-security-fingerprintstops at "No fingerprint sensor detected". Touch ID isn't a USB reader of its own: it sits behind the T1's Secure Enclave, inside the "iBridge" device (05ac:8600).pacman -S --needed --noconfirm --ask 4 -- libfprint-git fprintd usbutils.libfprint-gitandfprintdconflict with T1Bridge's pair, so--ask 4would replace it and leave the sensor with no driver.This change:
Apple USB SEP Interfacecounts as a reader. The T1 exposes that interface only in its macOS USB configuration, which T1Bridge selects at boot. In the default configuration it's absent and libfprint can't drive the sensor, so detection stays false there.libfprint-t1bridgeandfprintd-t1bridgeare installed, setup skips the package step instead of replacing them.enroll-duplicate), and T1Bridge's own setup usually enrolls one, so a Touch ID user who already has prints goes straight to verification. Nothing changes for other readers.The PAM and lock-screen part (
setup_pam_config,omarchy-apply-lock) is unchanged and runs as before, after verification.The Touch ID support
quattrogained since this was opened is for Apple Silicon Macs. The aurora driver is built intolibfprint-gitonly on aarch64 (the x86_64 build is unchanged, per its PKGBUILD) and needs/dev/sep-bio, which a T1 Mac doesn't have. On x86 no platform package names a T1 reader infingerprint-readers, and theenable-fingerprinthook is registered only for Apple Silicon, so setup still authenticates sudo and resolves that hook first, which does nothing on a T1.Testing
test/shell.d/hw-fingerprint-test.sh: a T1 exposing its SEP interface is detected; the same iBridge in its default configuration is not; the interface name on a non-Apple device is not.test/shell.d/fingerprint-package-test.sh: with T1Bridge's pair installed, setup never calls pacman; with no prints it enrolls; with a print it skips enrollment and verifies before PAM and lock setup; a failed verification leaves PAM untouched.quattro(11 November), both new test groups still fail on thequattroscripts and pass with this change../test/cli,fingerprint-invitation-test.shandsecurity-polkit-faillock-test.shpass. I didn't rerun the full./test/shellsuite.linux-omarchy7.2.15-1, T1Bridge 0.1.12 with one finger enrolled. The installedomarchy-hw-fingerprintreturns 1 there and this branch's returns 0. I ran this branch's two scripts against the installed Omarchy (PATHpointing at them,OMARCHY_PATH=/usr/share/omarchy). Setup printed "Using T1Bridge's fingerprint driver for Touch ID.", made no pacman call, said "Touch ID already has an enrolled fingerprint." instead of enrolling, verification matched, and it configured the lock screen.pacman -Qshowed the same packages before and after:libfprint-t1bridgeandfprintd-t1bridge, and nolibfprint-git.sudo fprintd-enroll -f left-index-finger "$USER"completed, and enrolling an already-enrolled finger returnedenroll-duplicate.