Repository navigation
Shrink the screensaver font so the logo fits on a 1080p panel at scale 2 - #14702
omarchybot wants to merge 2 commits into
Conversation
The screensaver drew at a fixed 18pt in every terminal, so on a 1080p panel at scale 2 (what Hyprland's "auto" picks for ~143 DPI) the fullscreen terminal is 66 columns and ttfx centre-crops the 81-column logo to "MARCH". The launcher now sizes the font per monitor, up to 18, from the art's width and height and the monitor's logical size, and passes it to all four terminals, so the size lives in one place rather than in two config files and two flags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Custom art thousands of columns wide floored the computed size to 0, which no terminal accepts; past 6pt the art is noise anyway, so it is cropped there instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
| case "$*" in | ||
| 'monitors -j') | ||
| printf '[{"name":"DP-1","specialWorkspace":{"name":""}},{"name":"DP-2","specialWorkspace":{"name":"special:scratchpad"}}]\n' | ||
| printf '[{"name":"DP-1","width":2560,"height":1440,"scale":1,"transform":0,"specialWorkspace":{"name":""}},{"name":"DP-2","width":1920,"height":1080,"scale":2,"transform":0,"specialWorkspace":{"name":"special:scratchpad"}}]\n' |
There was a problem hiding this comment.
The new tests only check landscape monitors through foot. They never exercise rotated monitors, art tall enough to limit the font size, or the new arguments for Alacritty, Ghostty, and Kitty. Mistakes in those paths could pass these checks and leave users with cropped art or a screensaver that does not open. Add cases for those paths.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
This is a nice fix for #9027. Heads-up on one interaction: #14622 lets a theme override the screensaver art. If that lands, (It also touches the same |
|
Not reviewed yet: the classification is unsettled, so nothing was labelled or run. Claude Opus 5.5 read the diff at 6efecd6 and classed it as a bug fix for #9027. The second opinion (Codex Medium) is reachable, but it did not classify this pull request because omabot's daily cap of 500 reviews was already used up, and a class needs both models to agree. Because there was no agreed class, it was not verified on a worker and the suite was not run. This waits on a classification pass that the second opinion takes part in. Once that pass agrees on a class, the pull request gets the full review and the worker run. |
The screensaver draws at a fixed 18pt in every terminal. On a 1920x1080 panel at scale 2, which is what Hyprland's
"auto"picks for a ~143 DPI laptop screen and so what a stock install gets, the fullscreen terminal is 960x540 logical pixels and 66 columns wide. ttfx sizes its canvas to the terminal and centre-crops the 81-column logo, so it reads "MARCH": theOis cut in half at the left edge and theYis gone off the right.omarchy-launch-screensavernow picks a font size for each monitor, the largest up to 18 at which the art fits that monitor's logical size: width and height divided by scale, swapped for a rotated output, measured against the art's columns and rows plus a column of margin on each side. The column count is measured withLC_ALL=C.UTF-8so the block characters count as one column each whatever locale the launcher runs under. The size is never below 6pt, so very wide custom art is still cropped rather than given a size the terminal rejects. Where the art already fits, nothing changes: a 1920x1080 monitor at scale 1 still gets 18pt.The size goes to all four terminals on the command line, and the
size = 18lines in the foot and alacritty screensaver configs are removed, so the launcher is the only place it is set.Fixes #9027