Repository navigation
Add ordered multi-selection to clipboard history - #14760
felix-antonio-sl wants to merge 1 commit into
Conversation
|
|
Ordered multi-select with newline-joined paste/copy is a nice clipboard-history upgrade, and piping the full payload to Product call: is multi-select something we want stock (discoverability of Ctrl+click / Ctrl+Space), or should it stay behind a setting? From a code/test read this otherwise looks ready for review. Nearby clipboard PRs (#14919 bound/prune, #15137 text/plain) touch adjacent surfaces — worth a quick conflict check. |
|
The current proposal makes multi-select available by default, with no setting. The picker footer shows Ctrl+click / Ctrl+Space, and the manual covers selection order and copy/paste behavior. |
Clipboard history currently pastes one saved entry at a time. This adds
Ctrl + clickandCtrl + Spaceto select text entries and combine them withEnter(paste) orShift + Enter(copy only). The full texts are joined with newlines in the order they were selected.Selected rows show their position in the group, and the preview displays the combined text. Marks survive filtering and history reordering, are pruned when entries are deleted or evicted, and reset on each opening. Images, file URI entries and
Alt + Enterretain their individual actions.The combined copy writes the complete payload to
wl-copythrough stdin, keeping large clips and shell syntax literal. It sends the existing Shift+Insert paste gesture only after copying succeeds; a copy failure keeps the selection available for retry. The rendered preview remains capped at 8192 characters.Includes the clipboard selection helper, regression coverage integrated into
test/shell.d/clipboard-selection-test.sh, and user-facing instructions in the manual. No new dependencies or migrations.Validation
clipboard-test.sh: 84 assertions passed after the change.qml-text-format-test.sh,color-reference-test.sh, QML parsing withqmlformat,bash -nandgit diff --check: passed.I also ran
./test/allbefore modifying the checkout, at base9d48fc4, with compositor-dependent checks disabled. The CLI suite passed. The shell suite ran 325 test files, with skipped checks in 27 files and these eight existing failures:config-test.shomarchy-pkgscheckout unavailabledefault-agent-test.shelsewhen-migration-test.shlaunch-browser-test.shpasswordless-grant-lifecycle-test.shomarchy-pkgscheckout unavailablesnapper-test.shomarchy-pkgscheckout unavailabletheme-intro-switch-test.shunowned-system-paths-test.shomarchy-pkgscheckout unavailableThose areas are unchanged by this PR. The graphical VM acceptance suite and pasting into a real destination application were not run as part of this contribution check.