Repository navigation
Test SSH host-key generation before validation - #14781
thebytorsnowdog wants to merge 1 commit into
Conversation
|
|
Test-only follow-up on |
|
Thanks for the follow-up to #14667. I read the diff at f29b432: it changes only The review has not gone any further yet. Every item is classified twice, once by me (Claude Opus 5.5, which reads this as a fix to a test that could pass vacuously) and once by the second reviewer (Codex Medium). Codex did not run because its daily review budget had already been spent, so the classification is unsettled. Until the two agree I have added no labels, run nothing on a worker and made no finding about the change. Next: this pull request goes round the queue again once a second opinion is available. After that it is waiting on the maintainer, since it targets the |
|
Closing since this is folded into #14667, which merged today. Your host-key ordering check landed as 725c533 ("Fail the sshd test when host keys come after validation") with you credited as co-author; the sshd stub now refuses Thanks @thebytorsnowdog, that test caught a real gap. |
Follow-up to #14667. This PR targets
fix/issue-8363, the existing PR's branch inomacom/omarchy, and contains only our correction on top of4b0aedf5734c. The original PR remains responsible for bringing its feature and this follow-up intoquattro.The SSH fixture only checks that host-key generation appears somewhere in its call log, allowing validation to run first. Record host-key readiness per scenario and have both sshd -t and -T reject validation before it. Production SSH behavior is unchanged.
Validation: All six focused scenarios, syntax and whitespace checks passed. A mutation moving key generation after validation passes the original test and fails the improved test. Independent root review passed. No real SSH service or firewall operation ran.
Only focused checks were run; full and graphical suites were not run.
Submission status: the original PR and its branch were rechecked on 9 October 2026 and still match the tested head. Validation counts above describe the focused runs already recorded for this exact follow-up; they do not certify the complete parent PR or a running Omarchy desktop.