Skip to content

Install the dev package pair in one transaction - #14844

Open
ekollof wants to merge 2 commits into
omacom:quattrofrom
ekollof:fix/pkg-test-single-transaction
Open

ekollof wants to merge 2 commits into
omacom:quattrofrom
ekollof:fix/pkg-test-single-transaction

Conversation

@ekollof

@ekollof ekollof commented Oct 10, 2026

Copy link
Copy Markdown

omarchy dev pkg-test installs settings-dev before building and installing omarchy-dev. When files move between the packages, the second upgrade removes paths installed by the first, leaving required helpers missing. This was reproduced in omacom/omarchy-pkgs#645 (comment).

Build all requested packages first, then pass their archives to one pacman -U transaction. A failed build installs nothing; an explicit single-package invocation retains its existing behavior.

Validation: command-level stubbed regressions check one transaction after both builds, no installation after a failed second build, and explicit package alias behavior. The tests reject the original implementation. The full CLI suite, bin style check, and git diff --check pass. No real package transaction was run on the development machine.

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

omarchy-dev-pkg-test now collects both package archives before installing them with one pacman -U call.

  • The default dev package pair installs together after both builds finish.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Build settings package] --> B{Build succeeds?}
  B -->|No| X[Exit without installing built packages]
  B -->|Yes| C[Build runtime package]
  C --> D{Build succeeds?}
  D -->|No| X
  D -->|Yes| E[Install both archives in one pacman call]
Loading

Reviews (1) · Last reviewed commit: "test(dev): cover paired package installa..." · Reviewed by Greptile

@omarchybot

Copy link
Copy Markdown
Collaborator

I read this against quattro at f7eaf22 and would class it as a bug fix: building both packages first and installing them in one pacman -U is the change the description says it is, and nothing in the diff reaches beyond bin/omarchy-dev-pkg-test and its new test.

The classification is not settled, so no label went on and nothing was run yet. Every item here is classified by two models separately, and the second (Codex Medium) did not run this time because its daily review budget was already used up. Without its answer this pull request has not been reproduced on a worker or given a second review, and none of the above is a verdict on whether it works.

It waits on that second classification. Once it agrees, the next pass reproduces the split-transaction file loss on a disposable worker against quattro and this head, and reports back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants