Repository navigation
Confirm secure session acquisition before reporting a lock - #14911
thebytorsnowdog wants to merge 1 commit into
Conversation
|
|
Confirming secure acquisition before reporting success is the right behavior for Heads-up: #14900 also touches |
|
Not verified yet: I read the change but did not run it, because the classification is not settled. I (Claude Opus 5.5) read this as a bug fix — today One thing from reading it against Next: once the classification is agreed, omabot will run it on a worker against |
|
Sharing native-VM evidence from a now-retired switching experiment, tested on 2026-10-24 with this PR at Stack: Omarchy 4.0.6-1, Hyprland 0.56.2-4, Quickshell 0.3.2.r7.g2b4501a-1, Qt 6.12, UWSM 0.27.1-1, SDDM 0.21.0-7, QEMU/KVM. This was a local integration with the logind work in #14299/#15566 and an experimental SDDM switch command. The compositor-confirmed acquisition check worked in real sessions. The integration also refused handoff when the shell was stopped and One additional regression belongs in any fast-switching consumer: a PAM attempt started before handoff can complete after handoff. In the initial prototype:
Both applications survived, and A was confirmed secure at the greeter before the late completion. Acquisition confirmation therefore needs a separate authentication-lifecycle guard for switching. This finding concerns the composed switching prototype; this PR's acquisition-reporting change alone does not introduce that handoff. A later local prototype paused/aborted outstanding authentication and invalidated old completion/authorization replies. Its real delayed-PAM regression passed: inactive A stayed compositor-locked, direct VT return stayed locked, and a fresh native PAM attempt was required. Persisting the pause across locker restart was covered by offscreen Quickshell controller tests; real crash-during-handoff coverage remained unfinished. The original PAM file was restored exactly after each fixture. Fingerprint hardware was not tested; its pending-attempt path also deserves coverage. These are archived integration observations, not a full-suite or production-readiness signoff. The separate session/greeter findings are relevant to #16100. |
Manual locking can currently report success when the shell refuses the request or has not acquired the compositor lock. Require both an accepted request and a subsequent status response with boolean
secure: truebefore succeeding.Request/status calls share a five-second deadline. Refusal, unavailable IPC, invalid status or timeout returns nonzero, explains the failure on stderr and attempts a bounded critical notification. Keyboard reset, 1Password locking and ordered screensaver cleanup follow confirmed acquisition.
Validation: all 15 cases in
test/shell.d/system-lock-test.shpass, including delayed acquisition, missing PAM, unavailable shell, malformed status, stalled IPC/notifications and successful post-lock behavior. Bash syntax, command metadata and style checks pass.Release still needs a running Omarchy desktop to verify actual lock acquisition and failure presentation. These tests use stubs; this change reports acquisition failures and does not change suspend's separate locking policy.