Repository navigation
Keep plugin clones out of the omarchy. namespace for a user named omarchy - #15142
omarchybot wants to merge 1 commit into
Conversation
…rchy A clone is named <username>.<id>, so for the user omarchy, cloning omarchy.menu produced omarchy.menu again. The shell rejects any third-party plugin in the omarchy. namespace, but the clone command still reported success: its discovery check and the enable call both matched the built-in of the same id, so it re-enabled the built-in and announced the clone. A derived id that lands in omarchy. now falls back to local.<id>, the scheme clones used before the username prefix. Fixes #12678 Co-Authored-By: Codex Medium <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
This competes with #7366, which fixes the same bug (#7118) the same way and was opened first, on 2026-08-18. Both check the derived clone id rather than the username, so both cover #12718 touches the same script but does not fix this bug: its username check accepts The one thing here that #7366 lacks is a test for the Checked by reading all three diffs against |
omarchy plugin clonenames a clone<username>.<id>. For a user namedomarchy, cloningomarchy.menugives backomarchy.menu, an id in the namespace the shell reserves for built-ins, soPluginRegistryrejects the clone and logs that only to the quickshell log. The command still reports success: its discovery check asks the live shell whether a plugin with that id exists, and the built-in of the same name answers, soomarchy-plugin-enablere-enables the built-in and the user is told the clone replaced it.When the derived id would start with
omarchy., the clone now getslocal.<id>, the scheme clones used before the username prefix. Checking the derived id rather than the username also covers a username likeomarchy.dev.clonedFromstill points at the built-in, so routing, bar placement andomarchy plugin removework as for any other clone. The help names the fallback, andplugin-clone-test.shcovers both usernames.On a worker whose login user is
omarchy, cloningomarchy.weatheronquattroprinted "switched to omarchy.weather" while the shell listed only the built-in and logged the rejection. With this change,omarchy.menuclones tolocal.menu, which the shell loads and enables, andomarchy plugin remove local.menurestores the built-in. The new test fails against the old script.Fixes #12678
🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex Medium.