Repository navigation
Conversation
The field only took focus once, when the lock surface was created, before the compositor had activated it, so typing went nowhere until a click. Claude-Session: https://claude.ai/code/session_01XFh5eEKfnMU4nauT1rSfK3
|
I tested the open PRs for the lock screen password field losing focus (#6858, #14613, #12525) on my laptop. Each one was merged into current
I'd go with #15362. It passed every scenario, refocuses only while its lock surface is the active window (so other monitors don't retry), is the closest to Suggestion: add The harness can't reproduce the initial surface-activation race from #6858 offscreen, so a lid-close/resume check on real hardware is still worth doing before merging. |
|
Thanks @casmith. Reviewed at What was checked. I read the diff against Where this one does less. What this adds. The fixture in Next: waiting on the maintainer to choose between the competing fixes. You don't need to change anything here. |
…g source The regex test passed on a no-op handler and failed on a reformat. This hosts the real LockView in a window and takes focus from the field the ways it is lost: to another item, and dropped to the surface as on resume. It checks the field takes it back each time, has it after a password check, and leaves it alone while input is disabled. Adapted from the fixture in omacom#15362. Co-Authored-By: Clay Smith <casmith@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Real-hardware lid-close/resume check, as suggested above: at Machine: Lenovo ThinkPad P17 Gen 1, built-in keyboard ( Setup: the onWindowActiveChanged: { console.log("omarchy lock-test windowActive=" + windowActive + " fieldFocus=" + passwordInput.activeFocus); Qt.callLater(restorePasswordFocus) }
Procedure: lid close → wait ~10 s → open → wait ~3 s → type the password without clicking → wait ~10 s and type again → click only if that still fails. Trace (identical both cycles, with sleeps of ~45 s and ~22 min): So after resume the window stays inactive for the rest of the lock. Both handlers fire only on the way down and are then rejected by the Same boot, same machine, same procedure, each fix tested on its own:
The offscreen harness above can't reach this path (as noted there), so on this hardware the behavioural fixture's "resume" pass doesn't carry over to a real suspend. The fixture is still useful, as the review says, minus the |
|
Thanks @mudiam, that settles the open question from the earlier review. Re-read at What changed. The resume failure in the earlier review was a source trace nobody had reproduced. The lid-close test above reproduces it on real hardware (2/2), and its log shows the mechanism the trace described: after resume What that means for the competing fixes. The recommendation is unchanged: #8560 is older and its Next: waiting on the maintainer to choose between the competing fixes. Nothing is needed from you, @casmith. |
|
On the missing evidence for #8560: I ran that lid-close check about an hour before this review, on the same machine and boot with #8560 installed alone. It passes 2/2: focus is reclaimed ~85 ms into suspend, before the keyboard returns, and typing works after resume without a click. Trace and details: #8560 (comment) |
|
Thanks @mudiam, that was the missing piece. Re-read at What changed. The earlier review said nobody had yet run a lid-close check on #8560. Your report on #8560 (comment) covers that: 2/2 pass on the same machine where this one fails 2/2. Its trace fits the code. #8560 reclaims focus when the field loses it, without checking Your fixture. The behavioural test from this pull request is now in #8560 (commit Next: the recommendation is still #8560, and choosing between the competing fixes is up to the maintainer. Nothing is needed from you, @casmith. |
…g source The regex test passed on a no-op handler and failed on a reformat. This hosts the real LockView in a window and takes focus from the field the ways it is lost: to another item, and dropped to the surface as on resume. It checks the field takes it back each time, has it after a password check, and leaves it alone while input is disabled. Adapted from the fixture in omacom#15362. Co-Authored-By: Clay Smith <casmith@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit f500908)
…eld keeps the keyboard after a suspend or a wrong password (general-0003) (#297) After a suspend and resume, and after a wrong password, the native lock's password field had no keyboard focus: typing did nothing until the field was clicked. The field only took focus when the lock view was built and when inputEnabled changed, and inputEnabled stays true across a suspend. While a password is checked the field is disabled, and Qt gives focus back to the re-enabled field only if nothing else took it meanwhile. - general-0003, the same in both recipes, from fork asus/v4-5-0-rc1 (28a967beb..c5887be86, upstream's four commits, squashed): the field takes focus back whenever it loses it while the lock takes input, and once a password check ends. The preview, built with input disabled, is left alone. - It is omacom/omarchy#8560 (head 39691c1e) as is, for omacom/omarchy#9180: upstream's triage recommends it, and it is the one open fix with a lid close and resume passing on hardware. omacom/omarchy#15362 (refocus on Window.active) failed on resume and is not used. - Its lock-focus-recovery-test.sh fails 5 of 6 checks without the patch and passes with it. - In the general- series: the bug is stock Omarchy's, not the hardware's. - pkgrel 1.108 in both recipes; sha256sums, DELTA and NOTES.md updated. Fixes #295 Co-authored-by: rdoupe <1207041+rdoupe@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The password field asked for focus once, when the lock surface was created. That's before the compositor gives the surface keyboard focus, so after locking (especially when the screen wakes up) typing went nowhere until you clicked the field. The field now takes focus when the surface gains keyboard focus, when something else takes focus from it, and after a password check finishes. It does this from events, with no timer.
Adds
lock-password-focus-test.sh, which fails without the fix.