Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; the previous ignored-file deletion issue is fixed. SummaryPlugin removal now backs up checkouts containing local work instead of deleting them.
No new issues found. Tests were not run.
|
|
Thanks for this. I read the diff, One thing I did check, in a scratch repository and not with your code: Greptile is right that ignored files fall through. Adding only the English manual chapter is correct. The translation sync workflow updates the other languages. Next: this comes round again once the classification is settled. Then it gets a reproduction on a worker (fails on |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed at 60945c7, and it does what it says. The ignored-file case from the last review is fixed: What ran, on a disposable worker built from the Omarchy ISO:
The change is proportionate: one predicate in Second opinion: Codex Medium reviewed it in two rounds. In the first it listed cases the check does not catch: a commit reachable only from the reflog, hooks or config edited inside Nothing is left for you to do. This now waits on the maintainer. |
omarchy plugin removedeleted any plugin folder that was a git checkout, on the grounds that "its git repo remains upstream". That isn't true when the checkout holds work of its own: uncommitted edits, untracked files, unpushed commits or stashes were deleted withrm -rf, while the prompt said nothing would be lost.Now a checkout is deleted only if git confirms that everything in it is also upstream. Anything else goes through the existing backup path, which moves the folder to
.<id>.bak.<timestamp>, the same as a hand-made folder. Becauseomarchy plugin updatemergesFETCH_HEADwithout moving the remote-tracking refs, commits it brought in count as upstream. A checkout that has only been updated is still deleted.The manual is updated to describe the new rule.
Testing
test/shell.d/plugin-remove-test.sh: a clean checkout and a checkout updated from upstream are deleted; uncommitted, untracked, committed-but-unpushed and stashed work is backed up.🤖 Generated with Claude Code