Repository navigation
Check for known issues, PRs and released fixes before reporting a crash - #15737
paulogeyer wants to merge 1 commit into
Conversation
[Medium impact] The change affects the crash-diagnosis and reporting workflow. The PR appears safe to merge, with a non-blocking gap in searches for Omarchy's package fixes. Findings
SummaryAdds a known-issue search before every crash report.
Reviews (1) · Last reviewed commit: "Check for known reports before writing a..." · Reviewed by Greptile |
| For a program Omarchy only installs, look for its upstream tracker the same way | ||
| (the project's own issue tracker, or `https://gitlab.archlinux.org` for Arch | ||
| packaging). Search there, read only. |
There was a problem hiding this comment.
Known package fixes get missed
The new search step never checks omacom/omarchy-pkgs, although Omarchy's package recipes live there. A crash caused by Omarchy's packaging can therefore miss an existing fix and still lead to a duplicate report. Add the package-source check described in this PR, search omacom/omarchy-pkgs for matching issues, PRs and commits, and include that repository in the fallback links.
There was a problem hiding this comment.
Already covered in f4094fb: it searches omacom/omarchy-pkgs issues, PRs and commits when the package appears in pacman -Sl omarchy, and adds omarchy-pkgs to the fallback links.
The diagnose-crash skill searches issues only when the crash is an Omarchy bug, and it never checks pull requests or whether a fix has already landed. Crash reports still come in for problems that are fixed on the default branch or already have an open PR.
This adds a "Check whether it is already known" step to
SKILL.md, before the report. It runs for every crash:omacom/omarchyissues, pull requests and commits, open and closed, by binary, signal, top frames and error strings.pacman -Sl omarchy, for examplelinux-omarchyorhyprland), searchomacom/omarchy-pkgsthe same way, since its recipes and their fixes live there.ghis missing or not logged in, give GitHub search links for both repos instead of installing or logging in.reporting.mdgains the matching pull-request search.test/shell.d/diagnose-crash-dedupe-test.shchecks the new guidance and that no skill names the old repo.This builds on the PR-search idea from #6959, which uses the old
basecamp/omarchyname thatgh searchno longer finds. It is compatible with #14115 and doesn't touchcontributing.mdor the bug template.Test: the new test fails on stock and passes 7/7 with the patch.
bash -nandgit diff --checkare clean.