Skip to content

Check for known issues, PRs and released fixes before reporting a crash - #15737

Open
paulogeyer wants to merge 1 commit into
omacom:quattrofrom
paulogeyer:crash-dedupe
Open

paulogeyer wants to merge 1 commit into
omacom:quattrofrom
paulogeyer:crash-dedupe

Conversation

@paulogeyer

Copy link
Copy Markdown
Contributor

The diagnose-crash skill searches issues only when the crash is an Omarchy bug, and it never checks pull requests or whether a fix has already landed. Crash reports still come in for problems that are fixed on the default branch or already have an open PR.

This adds a "Check whether it is already known" step to SKILL.md, before the report. It runs for every crash:

  • Record the Omarchy version and channel, plus the crashing package's version.
  • Search omacom/omarchy issues, pull requests and commits, open and closed, by binary, signal, top frames and error strings.
  • For Omarchy code, check the default branch and releases. A fix that is merged but not yet released isn't reported again.
  • If the package comes from Omarchy's own repository (it appears in pacman -Sl omarchy, for example linux-omarchy or hyprland), search omacom/omarchy-pkgs the same way, since its recipes and their fixes live there.
  • For other programs, search their own tracker, read-only.
  • If there's a match, link it and suggest a thumbs-up or a comment with only new information instead of a new issue. Nothing is posted without the user's yes.
  • If gh is missing or not logged in, give GitHub search links for both repos instead of installing or logging in.

reporting.md gains the matching pull-request search. test/shell.d/diagnose-crash-dedupe-test.sh checks the new guidance and that no skill names the old repo.

This builds on the PR-search idea from #6959, which uses the old basecamp/omarchy name that gh search no longer finds. It is compatible with #14115 and doesn't touch contributing.md or the bug template.

Test: the new test fails on stock and passes 7/7 with the patch. bash -n and git diff --check are clean.

@greptile-apps

greptile-apps Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects the crash-diagnosis and reporting workflow.

The PR appears safe to merge, with a non-blocking gap in searches for Omarchy's package fixes.

Findings

  1. P2 Known package fixes get missed ▶

Summary

Adds a known-issue search before every crash report.

  • Crash diagnosis checks for known reports and fixes before suggesting a new one.

Reviews (1) · Last reviewed commit: "Check for known reports before writing a..." · Reviewed by Greptile

Comment on lines +106 to +108
For a program Omarchy only installs, look for its upstream tracker the same way
(the project's own issue tracker, or `https://gitlab.archlinux.org` for Arch
packaging). Search there, read only.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Known package fixes get missed

The new search step never checks omacom/omarchy-pkgs, although Omarchy's package recipes live there. A crash caused by Omarchy's packaging can therefore miss an existing fix and still lead to a duplicate report. Add the package-source check described in this PR, search omacom/omarchy-pkgs for matching issues, PRs and commits, and include that repository in the fallback links.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already covered in f4094fb: it searches omacom/omarchy-pkgs issues, PRs and commits when the package appears in pacman -Sl omarchy, and adds omarchy-pkgs to the fallback links.

@omarchybot omarchybot added the enhancement New feature or request label Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants