Skip to content

Offer Remove > Dictation > Voxtype for every voxtype package - #15788

Closed
omarchybot wants to merge 1 commit into
quattrofrom
fix/issue-11749
Closed

omarchybot wants to merge 1 commit into
quattrofrom
fix/issue-11749

Conversation

@omarchybot

Copy link
Copy Markdown
Collaborator

Remove > Dictation and Remove > Dictation > Voxtype were only offered when the voxtype-bin package was installed. Voxtype can also come from the AUR voxtype (a source build) or voxtype-bin-rc; with either of those the dictation keys are bound and the installer sees voxtype as present, because both check for the voxtype command, but the menu offers no way to remove it.

The rows now look for any of the three packages. They stay on package presence rather than the command, as the Ollama row does, so the menu offers removal only for installs the remover can actually uninstall: a voxtype binary dropped on the PATH by hand would show the row without anything for omarchy-pkg-drop to act on.

This is the menu half of #11749. The remover half is #14451, which makes omarchy-remove-dictation-voxtype drop all three packages instead of only voxtype-bin; until it lands, removing an AUR voxtype from this menu entry disables the service and deletes the config but leaves the package installed, as running the remover directly does today. The installer half of the report no longer applies: omarchy-install-dictation-voxtype already skips installing voxtype-bin when the voxtype command is present.

test/shell.d/remove-dictation-menu-test.sh evaluates both rows' guards with each package installed alone, with only Superwhisper, and with nothing. It fails on quattro and passes here. Reviewed by Claude Opus 5.5 and, as a second opinion, Codex Medium, which found no defect.

Fixes #11749

The Remove rows only looked for voxtype-bin, so with the AUR voxtype or voxtype-bin-rc installed, dictation worked but could not be removed from the menu. Gate them on the same packages the remover drops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The menu changes appear safe to merge within the stated scope.

Summary

Offers Remove > Dictation > Voxtype when voxtype-bin, voxtype-bin-rc, or voxtype is installed.

  • The Dictation menu offers Voxtype removal for all three package names.

Acknowledgment: omarchybot states that removing alternate Voxtype packages still leaves the package installed; that work is deferred to #14451.

Reviews (1) · Last reviewed commit: "Offer Remove > Dictation > Voxtype for e..." · Reviewed by Greptile

@omarchybot omarchybot added bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 18, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator Author

Reviewed and verified on a disposable Omarchy worker at 13ae838, against quattro at 4e059ac.

  • Reproduction: on the worker I built and installed a stand-in voxtype package through pacman (no voxtype-bin), then evaluated both rows' when guards with the real omarchy-pkg-present. With quattro's menu, Remove > Dictation and Remove > Dictation > Voxtype are both hidden. With this branch's menu, both are offered.
  • Tests: test/shell.d/remove-dictation-menu-test.sh fails on quattro's menu file and passes on this head. ./test/cli and the test/shell.d/menu* tests pass on the worker.
  • Second opinion: Codex Medium reviewed it. It found the change proportionate and the package names correct, and confirmed separately that the test fails if either guard is reverted. That agreement is with conclusions already written down here, so its independence is not guaranteed. It raised one point, which this description already discloses: with voxtype or voxtype-bin-rc installed, the remover this row launches still drops only voxtype-bin, so it disables the service and deletes the config but leaves the package installed. Drop every voxtype package when removing dictation #14451 fixes that, and the two belong together.
  • The commit message says the rows are gated on "the same packages the remover drops". That is only true once Drop every voxtype package when removing dictation #14451 has landed.

Nothing is left for the author. This waits on the maintainer, alongside #14451.

@omarchybot omarchybot closed this Oct 31, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator Author

Only giving parity of remove when install has happened through our default setups.

Closed by the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dictation installer and menu check for voxtype-bin instead of the voxtype command

1 participant