Repository navigation
Offer Remove > Dictation > Voxtype for every voxtype package - #15788
Closed
omarchybot wants to merge 1 commit into
Closed
omarchybot wants to merge 1 commit into
omarchybot wants to merge 1 commit into
Conversation
The Remove rows only looked for voxtype-bin, so with the AUR voxtype or voxtype-bin-rc installed, dictation worked but could not be removed from the menu. Gate them on the same packages the remover drops. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
[Low impact] The menu changes appear safe to merge within the stated scope. SummaryOffers Remove > Dictation > Voxtype when
Acknowledgment: omarchybot states that removing alternate Voxtype packages still leaves the package installed; that work is deferred to #14451. Reviews (1) · Last reviewed commit: "Offer Remove > Dictation > Voxtype for e..." · Reviewed by Greptile |
Collaborator
Author
|
Reviewed and verified on a disposable Omarchy worker at 13ae838, against
Nothing is left for the author. This waits on the maintainer, alongside #14451. |
Collaborator
Author
|
Only giving parity of remove when install has happened through our default setups. Closed by the maintainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove > Dictation and Remove > Dictation > Voxtype were only offered when the
voxtype-binpackage was installed. Voxtype can also come from the AURvoxtype(a source build) orvoxtype-bin-rc; with either of those the dictation keys are bound and the installer sees voxtype as present, because both check for thevoxtypecommand, but the menu offers no way to remove it.The rows now look for any of the three packages. They stay on package presence rather than the command, as the Ollama row does, so the menu offers removal only for installs the remover can actually uninstall: a
voxtypebinary dropped on the PATH by hand would show the row without anything foromarchy-pkg-dropto act on.This is the menu half of #11749. The remover half is #14451, which makes
omarchy-remove-dictation-voxtypedrop all three packages instead of onlyvoxtype-bin; until it lands, removing an AURvoxtypefrom this menu entry disables the service and deletes the config but leaves the package installed, as running the remover directly does today. The installer half of the report no longer applies:omarchy-install-dictation-voxtypealready skips installingvoxtype-binwhen thevoxtypecommand is present.test/shell.d/remove-dictation-menu-test.shevaluates both rows' guards with each package installed alone, with only Superwhisper, and with nothing. It fails onquattroand passes here. Reviewed by Claude Opus 5.5 and, as a second opinion, Codex Medium, which found no defect.Fixes #11749