Repository navigation
Conversation
…do -v Under the default verifypw=all, sudo -v asks for a password even when every command runs passwordless, so an unattended omarchy update stopped in the middle of its migrations on a NOPASSWD machine. Authorize by running a command instead, the way omarchy-update already does. Fixes omacom#15728
[Medium impact] The PR appears safe to merge; the previous test failure is fixed and no new actionable issues were found. SummaryThe migration now uses
Reviews (2) · Last reviewed commit: "test: deny sudo true in the quiet boot s..." · Reviewed by Greptile |
|
Thanks for tracking this down. This makes the same change as #15729, opened a day earlier for the same issue (#15728): both replace What was checked, on a disposable Omarchy worker with sudo set up like the report ( One defect here that #15729 does not have: this pull request leaves the existing This was reviewed by Claude Opus 5.5 alone. The second opinion (Codex Medium) did not run, because omabot's daily review quota was used up; the reviewer itself answered a ping. Without it the classification is unsettled, so this gets no labels for now and has not been closed. It waits on the maintainer to choose between this and #15729. |
|
Thanks for the follow-up commit: the existing The fix itself is the same change as #15729, opened a day earlier for the same issue (#15728) against Checked by Claude Opus 5.5 and, as an independent second opinion, Codex Medium, which agreed separately that this is a bug fix and was asked separately whether this duplicates #15729. Nothing was run for this head: the change to the migration is the same one already verified on a disposable Omarchy worker for #15729. |
Fixes #15728
Problem
On a machine with passwordless sudo (
NOPASSWD: ALLnext to the stock passworded rule),omarchy update -yaborts during migration1791898365("Speed up the boot menu and keep it quiet until a key is pressed"). The migration authorizes withsudo -v, and under sudo's defaultverifypw=all,-vdemands a password whenever any of the user's rules needs one — even though every command runs passwordless. Migrations run underbash -euo pipefail, so the failedsudo -vkills the update after packages were already upgraded, leaving the box half-updated.Fix
Authorize by running a command (
sudo true) instead ofsudo -v, exactly asbin/omarchy-updatealready does (authorize_update, with the same verifypw=all rationale in its comment) and asomarchy-update-stay-awakewas fixed (#9467). A denied prompt still fails the migration and leaves it pending, preserving the original intent of that code path.Test
New
test/shell.d/limine-quiet-migration-sudo-test.sh(auto-discovered), using a stubsudothat models the reported machine:-vfails with "a password is required" while real commands execute.sudo -vand the test fails (red).timeout: 1andquiet: yes(green).Related existing tests pass:
limine-defaults-test.sh,console-no-ansi-query-migration-test.sh,factory-reset-limine-hashes-test.sh,dgx-spark-boot-test.sh.