Skip to content

Keep the Ghostty screensaver opaque - #15992

Closed
nargothrondir wants to merge 1 commit into
omacom:quattrofrom
nargothrondir:fix/ghostty-screensaver-opacity
Closed

nargothrondir wants to merge 1 commit into
omacom:quattrofrom
nargothrondir:fix/ghostty-screensaver-opacity

Conversation

@nargothrondir

@nargothrondir nargothrondir commented Oct 19, 2026 •

Copy link
Copy Markdown
screensaver-comparison screensaver-before screensaver-after The screensaver is launched by `omarchy-launch-screensaver` in the user's terminal. For Ghostty it passes `default/ghostty/screensaver` with `--config-file`, which is loaded on top of the user's own config. Users who set a translucent background (`background-opacity` below 1) therefore get a see-through screensaver, because the screensaver config never resets the opacity. The Alacritty screensaver config already pins `opacity = 1.0`, so this brings Ghostty in line.

Change: add background-opacity = 1 to default/ghostty/screensaver.

Before (user config has background-opacity = 0.80): the wallpaper shows through the screensaver window.
After: the screensaver window is opaque.

Testing:

  • ghostty +validate-config accepts the file.
  • Ran the screensaver window in the running UI with background-opacity = 0.80 in the user config, before and after the change (screenshots attached).
  • ./test/all reports 18 failures in test/cli and test/shell. The same 18 fail on the base branch without this change, so they are unrelated to it.

🤖 Generated with Claude Code

The screensaver loads default/ghostty/screensaver on top of the user's
config. Users with a translucent Ghostty background (background-opacity)
therefore get a see-through screensaver, while the Alacritty screensaver
config already pins opacity to 1.0.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Adds background-opacity = 1 to default/ghostty/screensaver so the Ghostty screensaver stays opaque when the user's terminal is translucent.

  • Ghostty’s screensaver stays opaque with translucent user settings.

Reviews (1) · Last reviewed commit: "Keep the Ghostty screensaver opaque" · Reviewed by Greptile

@omarchybot omarchybot added bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 21, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 9152af0, nothing found to change.

Reproduced on a worker. On a fresh Omarchy install with Ghostty as the default terminal and background-opacity = 0.80 in ~/.config/ghostty/config, I ran omarchy-launch-screensaver force and screenshotted it. Without this change the wallpaper shows through the screensaver; with it the background is solid black (a strip along the bottom of the screen measured mean grey 2.9 before, 0 after). This matters beyond hand-edited configs: Glassy windows mode writes background-opacity = 0.65 into the theme's ghostty.conf (bin/omarchy-theme-set-glass), which the screensaver inherited the same way.

Tests. ./test/cli and test/shell.d/screensaver-workspace-test.sh pass on the worker with this tree.

Second opinion. Codex at medium effort reviewed it and found no defect: it agrees that a --config-file given on the command line is loaded after the user config and the theme file it includes, so background-opacity = 1 wins, and that the change is proportionate. It had my reasoning available, so treat that as agreement rather than independent confirmation.

Related, not blocking. Kitty has the same gap: its screensaver is launched with --override flags on top of the user's config and never resets background_opacity, and I saw the wallpaper through it on the worker too. Alacritty (opacity = 1.0) and foot (whose --config replaces the user's file) are fine. A Kitty fix would be a separate pull request. #15570 also edits default/ghostty/screensaver, for the background colour rather than its opacity, so whichever lands second needs a one-line merge.

Nothing is waiting on you; this is with the maintainer.

@omarchybot omarchybot removed ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review labels Oct 29, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

This now conflicts with quattro because the file it changes is gone there, and I don't think it needs rebasing.

The fix was right for the screensaver it was written against: I reproduced it on a worker on 21 October. Since then, fdbe182 (Launch the native Wayland screensaver) replaced the terminal screensaver with the omarchy-screensaver package, which draws a Wayland layer-shell overlay itself. That commit deleted default/ghostty/screensaver along with the Alacritty and Foot screensaver configs, and bin/omarchy-launch-screensaver now just execs /usr/lib/omarchy-screensaver/omarchy-screensaver. Nothing on quattro starts the screensaver in a terminal anymore, so a translucent Ghostty background-opacity can't show through it. Resolving the conflict would mean either dropping this change or adding back a config file nothing reads.

Checked: the current quattro tree for anything that still launches the screensaver in a terminal or reads a terminal screensaver config (none: idle, the menu and branding previews all go through the native launcher). Nothing was run, since there's nothing left to run. Codex Medium and muse-wonder (pi, thinking high) reviewed this separately and came to the same conclusion. Both had the question in front of them, so their agreement isn't fully independent.

This is waiting on the maintainer, and I'd recommend closing it. Thanks @nargothrondir for the fix and the clear before-and-after screenshots. If the native screensaver ever lets the desktop show through, that's an issue for the omarchy-screensaver package.

@nargothrondir

Copy link
Copy Markdown
Author

Closing this: the terminal-based screensaver it fixed was replaced by the native Wayland overlay in fdbe182 ("Launch the native Wayland screensaver"). default/ghostty/screensaver no longer exists on quattro, so the change no longer applies and the branch conflicts. The Kitty follow-up is moot for the same reason. Thanks for the review and the reproduction.

@nargothrondir
nargothrondir deleted the fix/ghostty-screensaver-opacity branch November 1, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants