Repository navigation
Keep the Ghostty screensaver opaque - #15992
nargothrondir wants to merge 1 commit into
Conversation
The screensaver loads default/ghostty/screensaver on top of the user's config. Users with a translucent Ghostty background (background-opacity) therefore get a see-through screensaver, while the Alacritty screensaver config already pins opacity to 1.0. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
[Low impact] This change appears safe to merge. SummaryAdds
Reviews (1) · Last reviewed commit: "Keep the Ghostty screensaver opaque" · Reviewed by Greptile |
|
Reviewed at 9152af0, nothing found to change. Reproduced on a worker. On a fresh Omarchy install with Ghostty as the default terminal and Tests. Second opinion. Codex at medium effort reviewed it and found no defect: it agrees that a Related, not blocking. Kitty has the same gap: its screensaver is launched with Nothing is waiting on you; this is with the maintainer. |
|
This now conflicts with The fix was right for the screensaver it was written against: I reproduced it on a worker on 21 October. Since then, fdbe182 (Launch the native Wayland screensaver) replaced the terminal screensaver with the Checked: the current This is waiting on the maintainer, and I'd recommend closing it. Thanks @nargothrondir for the fix and the clear before-and-after screenshots. If the native screensaver ever lets the desktop show through, that's an issue for the |
|
Closing this: the terminal-based screensaver it fixed was replaced by the native Wayland overlay in fdbe182 ("Launch the native Wayland screensaver"). default/ghostty/screensaver no longer exists on quattro, so the change no longer applies and the branch conflicts. The Kitty follow-up is moot for the same reason. Thanks for the review and the reproduction. |
Change: add
background-opacity = 1todefault/ghostty/screensaver.Before (user config has
background-opacity = 0.80): the wallpaper shows through the screensaver window.After: the screensaver window is opaque.
Testing:
ghostty +validate-configaccepts the file.background-opacity = 0.80in the user config, before and after the change (screenshots attached)../test/allreports 18 failures intest/cliandtest/shell. The same 18 fail on the base branch without this change, so they are unrelated to it.🤖 Generated with Claude Code